From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arpitha Raghunandan <98.arpi@gmail.com>,
brendanhiggins@google.com, skhan@linuxfoundation.org,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] lib: Convert test_printf.c to KUnit
Date: Fri, 21 Aug 2020 15:28:49 +0300 [thread overview]
Message-ID: <20200821122849.GS1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200821113710.GA26290@alley>
On Fri, Aug 21, 2020 at 01:37:10PM +0200, Petr Mladek wrote:
> On Mon 2020-08-17 09:06:32, Rasmus Villemoes wrote:
> > On 17/08/2020 06.30, Arpitha Raghunandan wrote:
> > > Converts test lib/test_printf.c to KUnit.
> > > More information about KUnit can be found at
> > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html.
> > > KUnit provides a common framework for unit tests in the kernel.
> >
> > So I can continue to build a kernel with some appropriate CONFIG set to
> > y, boot it under virt-me, run dmesg and see if I broke printf? That's
> > what I do now, and I don't want to have to start using some enterprisy
> > framework.
>
> I had the same concern. I have tried it.
Which raises an obvious question: did the people who convert this test this
themselves? Looks like a janitor work in the area without understanding the
area good enough.
Probably I will NAK all those patches from now on, until it will be good commit
messages and cover of risen aspects, including reference to before and after
outcome for passed and failed test cases.
Brendan, I guess the ball now on your side to prove this is good activity.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-21 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 4:30 [PATCH] lib: Convert test_printf.c to KUnit Arpitha Raghunandan
2020-08-17 7:06 ` Rasmus Villemoes
2020-08-21 4:54 ` Arpitha Raghunandan
2020-08-21 11:37 ` Petr Mladek
2020-08-21 12:19 ` Rasmus Villemoes
2020-10-12 20:13 ` Brendan Higgins
2020-10-12 20:48 ` Brendan Higgins
2020-08-21 12:28 ` Andy Shevchenko [this message]
2020-10-12 20:46 ` Brendan Higgins
2020-10-13 8:53 ` Arpitha Raghunandan
2020-10-13 9:55 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821122849.GS1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=98.arpi@gmail.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).