Re: [RFC PATCH V2] iomap: add support to track dirty state of sub pages

From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Yu Kuai <yukuai3@huawei.com>,
	david@fromorbit.com, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com
Subject: Re: [RFC PATCH V2] iomap: add support to track dirty state of sub pages
Date: Fri, 21 Aug 2020 14:05:22 +0100	[thread overview]
Message-ID: <20200821130522.GS17456@casper.infradead.org> (raw)
In-Reply-To: <20200821061019.GD31091@infradead.org>

On Fri, Aug 21, 2020 at 07:10:19AM +0100, Christoph Hellwig wrote:
> On Tue, Aug 18, 2020 at 05:50:19PM +0100, Matthew Wilcox wrote:
> > Looks like Christoph changed his mind sometime between that message
> > and the first commit: 9dc55f1389f9569acf9659e58dd836a9c70df217
> 
> No, as Darrick pointed out it was all about the header dependency.
> 
> > My THP patches convert the bit array to be per-block rather than
> > per-sector, so this is all going to go away soon ;-)
> 
> I've asked a while ago, but let me repeat:  Can you split out all the
> useful iomap bits that are not directly dependent on the new THP
> infrastructure and send them out ASAP?  I'd like to pre-load this
> work at least a merge window before the actual THP bits.

I've been working on that the past couple of days.  As always when
reviewing a patch series, I find things that need to be done differently.
And spot bugs (one pre-existing, one that I introduced).

You may not have noticed; I've sent out a couple of patch series to
linux-mm already this week:

https://lore.kernel.org/linux-mm/20200819150555.31669-1-willy@infradead.org/
https://lore.kernel.org/linux-mm/20200819184850.24779-1-willy@infradead.org/

plus this to linux-block:
https://lore.kernel.org/linux-block/20200817195206.15172-1-willy@infradead.org/

this patch series inadvertently breaks DAX and I need to debug that:
https://lore.kernel.org/linux-mm/20200804161755.10100-1-willy@infradead.org/

i also need to figure out what breaks for Hugh here (I may already have
fixed it, but I need to do more testing):
https://lore.kernel.org/linux-mm/20200629152033.16175-1-willy@infradead.org/

So the iomap chunks are next, and then I have another mm series in mind.
After all that is done, I'll have almost all the prep work merged for
5.10 and we can do the actual THP patchset in 5.11.  I'm sitting on
around 80 patches at this point although it varies from day to day
depending how I resplit things.