From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545D4C433DF for ; Fri, 21 Aug 2020 14:42:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19ABF207C3 for ; Fri, 21 Aug 2020 14:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598020937; bh=oZnskDyx49feGRU1KivrlcX9Ad2+BpqnA5lPTA64O8U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=N+dzOXa1bhJhGbYzq8MwzFXiKC3XflikijwdA5P237kfkXjP5EkGhi/hbCveGrEW0 rGtoY0NAFaTZ3G3onUPQW4vdwWg747QgEenVEYx2Ujsh86RAdR9bpj2k1D4qWkxil9 C1BLas+eA8B4jLlFzx/ghXXZVpd0MlI7X708qbxE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgHUOmL (ORCPT ); Fri, 21 Aug 2020 10:42:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:44628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbgHUOmK (ORCPT ); Fri, 21 Aug 2020 10:42:10 -0400 Received: from coco.lan (ip5f5ad5bf.dynamic.kabel-deutschland.de [95.90.213.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05D512078B; Fri, 21 Aug 2020 14:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598020928; bh=oZnskDyx49feGRU1KivrlcX9Ad2+BpqnA5lPTA64O8U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TM5fK7GvQnAs4QuEft/iwxbpoY78lVyQ499aIFK9Sa67v+FeZFjpsiiZREgfmjpP7 F3wg8pER3AL0vqDXvCJz2TcQ0e0v2xkCaUoU0CrC5EmmIP99YKxfqHltzvoTX1ZBz7 /XGjEqvRbxj0QEnDxNw/MfGzBLR1d5g80zBFWmO8= Date: Fri, 21 Aug 2020 16:41:58 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Cc: Greg Kroah-Hartman , Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , Jakub Kicinski , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Liuyao An , Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200821164158.22777f95@coco.lan> In-Reply-To: <20200819173558.GA3733@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Another quick question: Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: > > +#define DSS_REDUCE(x) ((x) > 0 ? ((x) - 1) : (x)) > Use generic macros for this? Do you know a generic macro similar to this? Or do you mean adding it to include/kernel.h? There are the atomic sub ones, but doesn't make sense here. The closest one I found was min_not_zero(), but this would take two args. Btw, I agree that the name here is a bit odd... I would have called such macro as 'dec_not_zero()'. Thanks, Mauro