From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CCEC433DF for ; Fri, 21 Aug 2020 20:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0047208E4 for ; Fri, 21 Aug 2020 20:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598042068; bh=jVmjVOTyttMGsCdhDF71uRaysTPYuV3BR9/r/IXdypY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uyU54AQXppLt5UItjESSPs9WjGpVuh9UOqB2avL4HPBdI/SWn8rsUklPSGQA9hnBH sdsu8BEPfBwdZWAILpOmpNhzNqynpcQlh6xWeSS1oKLR+UlVUmZDaurIam0tvLJ7mj mwIwkNxKykU7U1uEbrJ4zoBGsdLuDrxOTFVpjW80= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbgHUUeY (ORCPT ); Fri, 21 Aug 2020 16:34:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:42452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbgHUUeX (ORCPT ); Fri, 21 Aug 2020 16:34:23 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6E8720724; Fri, 21 Aug 2020 20:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598042063; bh=jVmjVOTyttMGsCdhDF71uRaysTPYuV3BR9/r/IXdypY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d4yPjzxXUhE3ZopSszNnSMNTK0B+xJ3arVVqyAf8/jWaAFU774bd2WYi7AkhYCtAP AfAQFZ5ZoK14w9mQFKnSJgJpEcTGRaSiPnskHRFY6x/xakc9833MPOSilfy7X8oqO9 7t657fq8PpCdTvhvpAEOLwQ5GgzFp56kuo/QnKvg= Date: Fri, 21 Aug 2020 16:34:21 -0400 From: Sasha Levin To: Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Gal Pressman , Shadi Ammouri , Yossi Leybovich , linux-rdma@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.8 55/62] RDMA/efa: Add EFA 0xefa1 PCI ID Message-ID: <20200821203421.GD8670@sasha-vm> References: <20200821161423.347071-1-sashal@kernel.org> <20200821161423.347071-55-sashal@kernel.org> <20200821194036.GB2811093@nvidia.com> <20200821195322.GC8670@sasha-vm> <20200821201952.GB2811871@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200821201952.GB2811871@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2020 at 05:19:52PM -0300, Jason Gunthorpe wrote: >On Fri, Aug 21, 2020 at 03:53:22PM -0400, Sasha Levin wrote: >> On Fri, Aug 21, 2020 at 04:40:36PM -0300, Jason Gunthorpe wrote: >> > On Fri, Aug 21, 2020 at 12:14:16PM -0400, Sasha Levin wrote: >> > > From: Gal Pressman >> > > >> > > [ Upstream commit d4f9cb5c5b224dca3ff752c1bb854250bf114944 ] >> > > >> > > Add support for 0xefa1 devices. >> > > >> > > Link: https://lore.kernel.org/r/20200722140312.3651-5-galpress@amazon.com >> > > Reviewed-by: Shadi Ammouri >> > > Reviewed-by: Yossi Leybovich >> > > Signed-off-by: Gal Pressman >> > > Signed-off-by: Jason Gunthorpe >> > > Signed-off-by: Sasha Levin >> > > drivers/infiniband/hw/efa/efa_main.c | 6 ++++-- >> > > 1 file changed, 4 insertions(+), 2 deletions(-) >> > >> > Wait, what? Why is this being autosel'd? >> >> Stable trees try to pick up device enablement patches (such as patches >> that add PCI IDs). I suppose that AUTOSEL get pretty eager to grab >> those. > >Is it so common that old drivers will work with new HW with just a >PCI_ID update? > >I would have guessed that is the minority situation So keep in mind that a lot of it is not brand new HW, but rather same HW repackaged by a different vendor, or HW that received minor tweaks but where the old driver still works. I suppose it's more common in the USB ID world these days, so I guess I'll give PCI IDs a closer look next time. -- Thanks, Sasha