Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Markus Mayer <markus.mayer@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Colin Ian King <colin.king@canonical.com>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
	Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds
Date: Sat, 22 Aug 2020 13:56:36 +0200	[thread overview]
Message-ID: <20200822115636.GA19975@kozik-lap> (raw)
In-Reply-To: <20200821165221.32267-1-mmayer@broadcom.com>

On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote:
> We would overrun the error_text array if we hit a TIMEOUT condition,
> because we were using the error code "ETIMEDOUT" (which is 110) as an
> array index.
> 
> We fix the problem by correcting the array index and by providing a
> function to retrieve error messages rather than accessing the array
> directly. The function includes a bounds check that prevents the array
> from being overrun.
> 
> This patch was prepared in response to
>     https://lkml.org/lkml/2020/8/18/505.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>

Your Signed-off-by does not match From field. Please run
scripts/checkpatch on every patch you send.

I fixed it up, assuming markus.mayer@broadcom.com is the valid email
address.

> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> 
> Changes since v1:
>     - Added link of the coverity report to the commit message.
>     - Added Florian's ack.
>     - Removed second "const" from get_error_text() return type

Florian was so kind to provide you with necessary tags - Fixes and
Reported-by. Always include them on resubmit of patches.

Thanks, applied.

Best regards,
Krzysztof