From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1651C433DF for ; Mon, 24 Aug 2020 09:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6CA12072D for ; Mon, 24 Aug 2020 09:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259600; bh=757PNobQ795Eu1IGN8HnNy53RSgjwC9oKfln1dCIZto=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MboFxqJekHL36OheX5Ro2N86G1xLxRhs3zzCTdJq3dlxh0d3yHZ3SScFD3/LMsC36 5DOWEV5757baeqVO6MavoqVtp7aAug4QmoyKsPeuCW+YTHBOW0r+jh6C67Qyot7w6h DAuWyyIWQ7CXB5dEUYah4bmzyxZ80ysmyh3oDrYU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730254AbgHXI77 (ORCPT ); Mon, 24 Aug 2020 04:59:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:44596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730380AbgHXI5b (ORCPT ); Mon, 24 Aug 2020 04:57:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D6D821775; Mon, 24 Aug 2020 08:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259451; bh=757PNobQ795Eu1IGN8HnNy53RSgjwC9oKfln1dCIZto=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O7MSn1qh6qL7Jf45n9ZOFKtacX6GWRBKxZzK8PWXsI2dTQlM4gSzufV05migXeu12 g1BW1Fz4MGvJF+CgDu+Bza7moabCtK/0ywoneSs3aj3hjgGGtuE8n5p0AgNZQsZz/e VDDGMRNnx+t+XF2Y5O0i/3L3HPMIAWxSGJ6HJWeY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 64/71] net: dsa: b53: check for timeout Date: Mon, 24 Aug 2020 10:31:55 +0200 Message-Id: <20200824082359.149158595@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200824082355.848475917@linuxfoundation.org> References: <20200824082355.848475917@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 774d977abfd024e6f73484544b9abe5a5cd62de7 ] clang static analysis reports this problem b53_common.c:1583:13: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage ent.port &= ~BIT(port); ~~~~~~~~ ^ ent is set by a successful call to b53_arl_read(). Unsuccessful calls are caught by an switch statement handling specific returns. b32_arl_read() calls b53_arl_op_wait() which fails with the unhandled -ETIMEDOUT. So add -ETIMEDOUT to the switch statement. Because b53_arl_op_wait() already prints out a message, do not add another one. Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations") Signed-off-by: Tom Rix Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/b53/b53_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 11f3993ab7f30..294be86420b6d 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1335,6 +1335,8 @@ static int b53_arl_op(struct b53_device *dev, int op, int port, return ret; switch (ret) { + case -ETIMEDOUT: + return ret; case -ENOSPC: dev_dbg(dev->dev, "{%pM,%.4d} no space left in ARL\n", addr, vid); -- 2.25.1