linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: [PATCH 4.19 65/71] powerpc/pseries: Do not initiate shutdown when system is running on UPS
Date: Mon, 24 Aug 2020 10:31:56 +0200	[thread overview]
Message-ID: <20200824082359.202438041@linuxfoundation.org> (raw)
In-Reply-To: <20200824082355.848475917@linuxfoundation.org>

From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

commit 90a9b102eddf6a3f987d15f4454e26a2532c1c98 upstream.

As per PAPR we have to look for both EPOW sensor value and event
modifier to identify the type of event and take appropriate action.

In LoPAPR v1.1 section 10.2.2 includes table 136 "EPOW Action Codes":

  SYSTEM_SHUTDOWN 3

  The system must be shut down. An EPOW-aware OS logs the EPOW error
  log information, then schedules the system to be shut down to begin
  after an OS defined delay internal (default is 10 minutes.)

Then in section 10.3.2.2.8 there is table 146 "Platform Event Log
Format, Version 6, EPOW Section", which includes the "EPOW Event
Modifier":

  For EPOW sensor value = 3
  0x01 = Normal system shutdown with no additional delay
  0x02 = Loss of utility power, system is running on UPS/Battery
  0x03 = Loss of system critical functions, system should be shutdown
  0x04 = Ambient temperature too high
  All other values = reserved

We have a user space tool (rtas_errd) on LPAR to monitor for
EPOW_SHUTDOWN_ON_UPS. Once it gets an event it initiates shutdown
after predefined time. It also starts monitoring for any new EPOW
events. If it receives "Power restored" event before predefined time
it will cancel the shutdown. Otherwise after predefined time it will
shutdown the system.

Commit 79872e35469b ("powerpc/pseries: All events of
EPOW_SYSTEM_SHUTDOWN must initiate shutdown") changed our handling of
the "on UPS/Battery" case, to immediately shutdown the system. This
breaks existing setups that rely on the userspace tool to delay
shutdown and let the system run on the UPS.

Fixes: 79872e35469b ("powerpc/pseries: All events of EPOW_SYSTEM_SHUTDOWN must initiate shutdown")
Cc: stable@vger.kernel.org # v4.0+
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
[mpe: Massage change log and add PAPR references]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200820061844.306460-1-hegdevasant@linux.vnet.ibm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/powerpc/platforms/pseries/ras.c |    1 -
 1 file changed, 1 deletion(-)

--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -118,7 +118,6 @@ static void handle_system_shutdown(char
 	case EPOW_SHUTDOWN_ON_UPS:
 		pr_emerg("Loss of system power detected. System is running on"
 			 " UPS/battery. Check RTAS error log for details\n");
-		orderly_poweroff(true);
 		break;
 
 	case EPOW_SHUTDOWN_LOSS_OF_CRITICAL_FUNCTIONS:



  parent reply	other threads:[~2020-08-24  8:59 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  8:30 [PATCH 4.19 00/71] 4.19.142-rc1 review Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 01/71] drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset() Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 02/71] perf probe: Fix memory leakage when the probe point is not found Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 03/71] khugepaged: khugepaged_test_exit() check mmget_still_valid() Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 04/71] khugepaged: adjust VM_BUG_ON_MM() in __khugepaged_enter() Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 05/71] btrfs: export helpers for subvolume name/id resolution Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 06/71] btrfs: dont show full path of bind mounts in subvol= Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 07/71] btrfs: Move free_pages_out label in inline extent handling branch in compress_file_range Greg Kroah-Hartman
2020-08-24  8:30 ` [PATCH 4.19 08/71] btrfs: inode: fix NULL pointer dereference if inode doesnt need compression Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 09/71] btrfs: sysfs: use NOFS for device creation Greg Kroah-Hartman
2020-08-25 18:19   ` Pavel Machek
2020-08-25 23:58     ` Sasha Levin
2020-08-24  8:31 ` [PATCH 4.19 10/71] romfs: fix uninitialized memory leak in romfs_dev_read() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 11/71] kernel/relay.c: fix memleak on destroy relay channel Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 12/71] mm: include CMA pages in lowmem_reserve at boot Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 13/71] mm, page_alloc: fix core hung in free_pcppages_bulk() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 14/71] ext4: fix checking of directory entry validity for inline directories Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 15/71] jbd2: add the missing unlock_buffer() in the error path of jbd2_write_superblock() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 16/71] scsi: zfcp: Fix use-after-free in request timeout handlers Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 17/71] mm/memory.c: skip spurious TLB flush for retried page fault Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 18/71] drm/amd/display: fix pow() crashing when given base 0 Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 19/71] kthread: Do not preempt current task if it is going to call schedule() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 20/71] spi: Prevent adding devices below an unregistering controller Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 21/71] scsi: ufs: Add DELAY_BEFORE_LPM quirk for Micron devices Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 22/71] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range on ARM Greg Kroah-Hartman
2020-08-25 19:46   ` Pavel Machek
2020-08-24  8:31 ` [PATCH 4.19 23/71] media: budget-core: Improve exception handling in budget_register() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 24/71] rtc: goldfish: Enable interrupt in set_alarm() when necessary Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 25/71] media: vpss: clean up resources in init Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 26/71] Input: psmouse - add a newline when printing proto by sysfs Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 27/71] m68knommu: fix overwriting of bits in ColdFire V3 cache control Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 28/71] svcrdma: Fix another Receive buffer leak Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 29/71] xfs: fix inode quota reservation checks Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 30/71] jffs2: fix UAF problem Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 31/71] ceph: fix use-after-free for fsc->mdsc Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 32/71] cpufreq: intel_pstate: Fix cpuinfo_max_freq when MSR_TURBO_RATIO_LIMIT is 0 Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 33/71] scsi: libfc: Free skb in fc_disc_gpn_id_resp() for valid cases Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 34/71] virtio_ring: Avoid loop when vq is broken in virtqueue_poll Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 35/71] tools/testing/selftests/cgroup/cgroup_util.c: cg_read_strcmp: fix null pointer dereference Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 36/71] xfs: Fix UBSAN null-ptr-deref in xfs_sysfs_init Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 37/71] alpha: fix annotation of io{read,write}{16,32}be() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 38/71] fs/signalfd.c: fix inconsistent return codes for signalfd4 Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 39/71] ext4: fix potential negative array index in do_split() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 40/71] ext4: dont allow overlapping system zones Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 41/71] ASoC: q6routing: add dummy register read/write function Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 42/71] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 43/71] i40e: Fix crash during removing i40e driver Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 44/71] net: fec: correct the error path for regulator disable in probe Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 45/71] bonding: show saner speed for broadcast mode Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 46/71] bonding: fix a potential double-unregister Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 47/71] s390/runtime_instrumentation: fix storage key handling Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 48/71] s390/ptrace: " Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 49/71] ASoC: msm8916-wcd-analog: fix register Interrupt offset Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 50/71] ASoC: intel: Fix memleak in sst_media_open Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 51/71] vfio/type1: Add proper error unwind for vfio_iommu_replay() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 52/71] kvm: x86: Toggling CR4.SMAP does not load PDPTEs in PAE mode Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 53/71] kvm: x86: Toggling CR4.PKE " Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 54/71] kconfig: qconf: do not limit the pop-up menu to the first row Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 55/71] kconfig: qconf: fix signal connection to invalid slots Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 56/71] efi: avoid error message when booting under Xen Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 57/71] Fix build error when CONFIG_ACPI is not set/enabled: Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 58/71] RDMA/bnxt_re: Do not add user qps to flushlist Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 59/71] afs: Fix NULL deref in afs_dynroot_depopulate() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 60/71] bonding: fix active-backup failover for current ARP slave Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 61/71] net: ena: Prevent reset after device destruction Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 62/71] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 63/71] hv_netvsc: Fix the queue_mapping in netvsc_vf_xmit() Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 64/71] net: dsa: b53: check for timeout Greg Kroah-Hartman
2020-08-24  8:31 ` Greg Kroah-Hartman [this message]
2020-08-25 19:56   ` [PATCH 4.19 65/71] powerpc/pseries: Do not initiate shutdown when system is running on UPS Pavel Machek
2020-08-26 11:14     ` Vasant Hegde
2020-08-24  8:31 ` [PATCH 4.19 66/71] efi: add missed destroy_workqueue when efisubsys_init fails Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 67/71] epoll: Keep a reference on files added to the check list Greg Kroah-Hartman
2020-08-24  8:31 ` [PATCH 4.19 68/71] do_epoll_ctl(): clean the failure exits up a bit Greg Kroah-Hartman
2020-08-24  8:32 ` [PATCH 4.19 69/71] mm/hugetlb: fix calculation of adjust_range_if_pmd_sharing_possible Greg Kroah-Hartman
2020-08-24  8:32 ` [PATCH 4.19 70/71] xen: dont reschedule in preemption off sections Greg Kroah-Hartman
2020-08-24  8:32 ` [PATCH 4.19 71/71] clk: Evict unregistered clks from parent caches Greg Kroah-Hartman
2020-08-26  8:07 ` [PATCH 4.19 00/71] 4.19.142-rc1 review Pavel Machek
2020-08-26  8:28   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824082359.202438041@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=hegdevasant@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).