From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CB1C433E1 for ; Mon, 24 Aug 2020 10:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E949E20738 for ; Mon, 24 Aug 2020 10:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgHXK4G (ORCPT ); Mon, 24 Aug 2020 06:56:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:42172 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbgHXK4D (ORCPT ); Mon, 24 Aug 2020 06:56:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 13496AC1D; Mon, 24 Aug 2020 10:56:32 +0000 (UTC) Date: Mon, 24 Aug 2020 12:55:59 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrew Morton , Wei Yang , Baoquan He , Pankaj Gupta Subject: Re: [PATCH v2 07/10] mm/memory_hotplug: simplify page onlining Message-ID: <20200824105559.GG6315@linux> References: <20200819175957.28465-1-david@redhat.com> <20200819175957.28465-8-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819175957.28465-8-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 07:59:54PM +0200, David Hildenbrand wrote: > We don't allow to offline memory with holes, all boot memory is online, > and all hotplugged memory cannot have holes. > > We can now simplify onlining of pages. As we only allow to online/offline > full sections and sections always span full MAX_ORDER_NR_PAGES, we can just > process MAX_ORDER - 1 pages without further special handling. > > The number of onlined pages simply corresponds to the number of pages we > were requested to online. > > While at it, refine the comment regarding the callback not exposing all > pages to the buddy. > > Acked-by: Michal Hocko > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Wei Yang > Cc: Baoquan He > Cc: Pankaj Gupta > Cc: Oscar Salvador > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3