From: Mira Ressel <aranea@aixah.de>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Cc: Mira Ressel <aranea@aixah.de>
Subject: [PATCH 1/2] veth: Initialize dev->perm_addr
Date: Mon, 24 Aug 2020 14:38:26 +0000 [thread overview]
Message-ID: <20200824143828.5964-1-aranea@aixah.de> (raw)
Set the perm_addr of veth devices to whatever MAC has been assigned to
the device. Otherwise, it remains all zero, with the consequence that
ipv6_generate_stable_address() (which is used if the sysctl
net.ipv6.conf.DEV.addr_gen_mode is set to 2 or 3) assigns every veth
interface on a host the same link-local address.
The new behaviour matches that of several other virtual interface types
(such as gre), and as far as I can tell, perm_addr isn't used by any
other code sites that are relevant to veth.
Signed-off-by: Mira Ressel <aranea@aixah.de>
---
drivers/net/veth.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index e56cd562a664..af1a7cda6205 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1342,6 +1342,8 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
if (!ifmp || !tbp[IFLA_ADDRESS])
eth_hw_addr_random(peer);
+ memcpy(peer->perm_addr, peer->dev_addr, peer->addr_len);
+
if (ifmp && (dev->ifindex != 0))
peer->ifindex = ifmp->ifi_index;
@@ -1370,6 +1372,8 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
if (tb[IFLA_ADDRESS] == NULL)
eth_hw_addr_random(dev);
+ memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
+
if (tb[IFLA_IFNAME])
nla_strlcpy(dev->name, tb[IFLA_IFNAME], IFNAMSIZ);
else
--
2.25.4
next reply other threads:[~2020-08-24 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 14:38 Mira Ressel [this message]
2020-08-24 14:47 ` [PATCH 2/2] vlan: Initialize dev->perm_addr Mira Ressel
2020-08-24 17:25 ` [PATCH 1/2] veth: " David Miller
2020-08-26 15:20 ` Mira Ressel
2020-08-26 15:28 ` David Miller
2020-08-26 16:29 ` Mira Ressel
2020-08-26 16:33 ` David Miller
2020-08-27 1:04 ` Mira Ressel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824143828.5964-1-aranea@aixah.de \
--to=aranea@aixah.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).