From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B2DAC433E1 for ; Mon, 24 Aug 2020 17:28:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B7BF2075B for ; Mon, 24 Aug 2020 17:28:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="CvPpBnyw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728378AbgHXR2O (ORCPT ); Mon, 24 Aug 2020 13:28:14 -0400 Received: from smtp-fw-9102.amazon.com ([207.171.184.29]:61345 "EHLO smtp-fw-9102.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbgHXR2H (ORCPT ); Mon, 24 Aug 2020 13:28:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1598290086; x=1629826086; h=date:from:to:cc:message-id:references:mime-version: in-reply-to:subject; bh=sJKVrhjRdjFhSQhYyBL/Jhi9uLQHVJpNK4GZYxSA/dc=; b=CvPpBnyw8hNNnY4IPnBFDrXoro9F1g0NILcb8GHoOD+YmiZ4Ofemxrqc dndVhC9tYiZEMmA0J5Osb7qa82j1Bd0RfhbR9BDsNZHZQhJLbBI3QHA1B J9rrjFAc6b4TIvjpuUxX/2/MtKeYKWInQuG8QJ6n+xPZRwsKu3nxmOSAc I=; X-IronPort-AV: E=Sophos;i="5.76,349,1592870400"; d="scan'208";a="70457034" Subject: Re: [PATCH v3 05/11] genirq: Shutdown irq chips in suspend/resume during hibernation Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-821c648d.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 24 Aug 2020 17:25:48 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1a-821c648d.us-east-1.amazon.com (Postfix) with ESMTPS id CCA4AA1B8E; Mon, 24 Aug 2020 17:25:41 +0000 (UTC) Received: from EX13D10UWA001.ant.amazon.com (10.43.160.216) by EX13MTAUWA001.ant.amazon.com (10.43.160.118) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 Aug 2020 17:25:15 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D10UWA001.ant.amazon.com (10.43.160.216) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 Aug 2020 17:25:15 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 Aug 2020 17:25:15 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id A16DC40770; Mon, 24 Aug 2020 17:25:15 +0000 (UTC) Date: Mon, 24 Aug 2020 17:25:15 +0000 From: Anchal Agarwal To: Thomas Gleixner CC: , , , , , , , , , , , , , , , , , , , , , , , , , Message-ID: <20200824172515.GA19449@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <87h7svqzxm.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87h7svqzxm.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 22, 2020 at 02:36:37AM +0200, Thomas Gleixner wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Fri, Aug 21 2020 at 22:27, Thomas Gleixner wrote: > > Add a new quirk flag IRQCHIP_SHUTDOWN_ON_SUSPEND and add support for > > it the core interrupt suspend/resume paths. > > > > Changelog: > > v1->v2: Corrected the author's name to tglx@ > > Can you please move that Changelog part below the --- seperator next > time because that's really not part of the final commit messaage and the > maintainer has then to strip it off manually > Ack. > > Signed-off-by: Anchal Agarwal > > Signed-off-by: Thomas Gleixner > > These SOB lines are just wrongly ordered as they suggest: > > Anchal has authored the patch and Thomas transported it > > which is clearly not the case. So the right order is: > I must admit I wasn't aware of that. Will fix. > Signed-off-by: Thomas Gleixner > Signed-off-by: Anchal Agarwal > > And that needs another tweak at the top of the change log. The first > line in the mail body wants to be: > > From: Thomas Gleixner Yes I accidentally missed that in this patch. Others have that line on all the patches and even v2 for this patch has. Will fix. > > followed by an empty new line before the actual changelog text > starts. That way the attribution of the patch when applying it will be > correct. > > Documentation/process/ is there for a reason and following the few > simple rules to get that straight is not rocket science. > > Thanks, > > tglx > > Anchal