From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A7BC433DF for ; Tue, 25 Aug 2020 08:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD7FE2071E for ; Tue, 25 Aug 2020 08:39:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729274AbgHYIjt (ORCPT ); Tue, 25 Aug 2020 04:39:49 -0400 Received: from mga18.intel.com ([134.134.136.126]:62291 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728786AbgHYIjq (ORCPT ); Tue, 25 Aug 2020 04:39:46 -0400 IronPort-SDR: 6hf9NM6ewjQSKZwP43xw4/WIGF6gqWLnwNiVLyha8zyY/fqXmKfYoZ48+qPa2x2swHtdm1Cmqm 3prENlFcsZ8A== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="143731051" X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="143731051" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 01:39:45 -0700 IronPort-SDR: khKc+1k2dfxF4I/hhwwK2jpkKpV+l8pJZgUuRxWOG5P6qT2C7oPwsHNpHHjbSHvSUUY3InWVO4 8r+GKvbUE2Vw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="328791951" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 25 Aug 2020 01:39:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kAUHs-00BHJo-Jf; Tue, 25 Aug 2020 11:26:36 +0300 Date: Tue, 25 Aug 2020 11:26:36 +0300 From: Andy Shevchenko To: Valentin Schneider Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , linux-kernel@vger.kernel.org, Dietmar Eggemann Subject: Re: [PATCH v1] sched/topology: Make compiler happy about unused constant definitions Message-ID: <20200825082636.GQ1891694@smile.fi.intel.com> References: <20200824153902.57875-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2020 at 06:09:41PM +0100, Valentin Schneider wrote: > On 24/08/20 16:39, Andy Shevchenko wrote: > > Compilation of almost each file ends up with > > > > In file included from .../include/linux/energy_model.h:10, > > from .../include/linux/device.h:16, > > from .../drivers/spi/spi.c:8: > > .../include/linux/sched/topology.h:30:27: warning: ‘SD_DEGENERATE_GROUPS_MASK’ defined but not used [-Wunused-const-variable=] > > 30 | static const unsigned int SD_DEGENERATE_GROUPS_MASK = > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > ... > > > > Make compiler happy by annotating the static constants with __maybwe_unused. > > > > That should see some use as long as the build is for SMP. This whole region > is guarded by #ifdef CONFIG_SMP, so an !SMP build shouldn't trigger this. Isn't SMP is default for most of the kernel builds? And honestly I didn't get the purpose of this comment. > With what config/kernel are you getting this? x86_64_defconfig from the kernel sources with some drivers added (SMP or so has not been touched, DEBUG_SHED was enabled once to confirm that another static const has same issue). -- With Best Regards, Andy Shevchenko