* [PATCH] dmaengine: pl330: fix instruction dump formatting
[not found] <CGME20200813204151eucas1p1c64a0880ba83013f87d0ca41242e533a@eucas1p1.samsung.com>
@ 2020-08-13 20:41 ` Łukasz Stelmach
2020-08-25 11:11 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Łukasz Stelmach @ 2020-08-13 20:41 UTC (permalink / raw)
To: Dan Williams, Vinod Koul, Philipp Zabel, dmaengine, linux-kernel
Cc: b.zolnierkie, Łukasz Stelmach
Instruction dump uses two printk() in a row to print one instruction. Use
KERN_CONT to prevent breaking the output in the middle.
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
drivers/dma/pl330.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 88b884cbb7c1..e1af6a470453 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -254,7 +254,7 @@ enum pl330_byteswap {
static unsigned cmd_line;
#define PL330_DBGCMD_DUMP(off, x...) do { \
printk("%x:", cmd_line); \
- printk(x); \
+ printk(KERN_CONT x); \
cmd_line += off; \
} while (0)
#define PL330_DBGMC_START(addr) (cmd_line = addr)
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: pl330: fix instruction dump formatting
2020-08-13 20:41 ` [PATCH] dmaengine: pl330: fix instruction dump formatting Łukasz Stelmach
@ 2020-08-25 11:11 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-08-25 11:11 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Dan Williams, Philipp Zabel, dmaengine, linux-kernel, b.zolnierkie
On 13-08-20, 22:41, Łukasz Stelmach wrote:
> Instruction dump uses two printk() in a row to print one instruction. Use
> KERN_CONT to prevent breaking the output in the middle.
Applied, thanks
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> drivers/dma/pl330.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 88b884cbb7c1..e1af6a470453 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -254,7 +254,7 @@ enum pl330_byteswap {
> static unsigned cmd_line;
> #define PL330_DBGCMD_DUMP(off, x...) do { \
> printk("%x:", cmd_line); \
> - printk(x); \
> + printk(KERN_CONT x); \
> cmd_line += off; \
> } while (0)
> #define PL330_DBGMC_START(addr) (cmd_line = addr)
> --
> 2.26.2
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-25 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200813204151eucas1p1c64a0880ba83013f87d0ca41242e533a@eucas1p1.samsung.com>
2020-08-13 20:41 ` [PATCH] dmaengine: pl330: fix instruction dump formatting Łukasz Stelmach
2020-08-25 11:11 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).