From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA9EC433E1 for ; Tue, 25 Aug 2020 13:39:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C28EE2071E for ; Tue, 25 Aug 2020 13:39:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="qoiOtbO8"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="D7ngUbdp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbgHYNjP (ORCPT ); Tue, 25 Aug 2020 09:39:15 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48189 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgHYNiz (ORCPT ); Tue, 25 Aug 2020 09:38:55 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id CED13C54; Tue, 25 Aug 2020 09:38:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 25 Aug 2020 09:38:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=3 wcQjRGLShGm1raIEqom+OIeoVvNYM8FsgyvofszE5w=; b=qoiOtbO8nKNuIebt7 lZ3tzQ7kTQlasHD7jkcHbi91fx7bBi7ciVmaZlfRwE0LWxUcWEjNvSCdKqD1dwtS GFEi6yLlnyg41ljtamRinQhSo3dQnp3+sUmzHE/YWqoMS3cH3ZK4jVlCZKIW5i2X 0dS8wz5NaJ8MR7av5XFrNWytbVLYeNlq3LvktvRjEoij3nzojMi+gXWBWOkxrvFv Br4mk0Jb1SMMdyFuAUxOuwhY2Dri6lSSgnQpXKlotcVXOXfnVRPRyUtRIypdrsh2 fmkWByOV//ZROGVX/KjY1cqpJjhgVnFaUZ/avOd6AEDku19ekHw9yBhkT+4cgEyo i/SHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=3wcQjRGLShGm1raIEqom+OIeoVvNYM8FsgyvofszE 5w=; b=D7ngUbdpoK8pQbd/pOzYVnTrDDkDyr8RrhXel5K3DyxwqzKpAHZ8Aigbg VGUTA8KB0fSPddxekGaZfObspFRG3JaIuW501aZGxO+3FM4pSSw+T5A3BR7oW1m8 aMeeJCOs/5VejoDzzjXPtgnfARm/fllV8wjFJ3ZjEJPq6sZTkOx1eB3OR0W4CkXI nfUOe1foL9N80DnR7B2RQ8FNhjgVdQyqLa2+p0MuXZWX04LW5D90saTJY6RQUmi/ L+petd5c26fgBN2xWYlxwNRafqY8bGG7Qc16TYqna9AGJa0lhPKqD5sd88ybeWYO nqWjAB4ByHzu2vTOO9J75GPglp2Hw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddvtddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedune curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 33FEE30600A9; Tue, 25 Aug 2020 09:38:52 -0400 (EDT) Date: Tue, 25 Aug 2020 15:38:51 +0200 From: Maxime Ripard To: Yu Kuai Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@siol.net, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] drm/sun4i: add missing put_device() call in sun8i_r40_tcon_tv_set_mux() Message-ID: <20200825133851.scnipngfpm6jyje5@gilmour.lan> References: <20200825114403.1392369-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200825114403.1392369-1-yukuai3@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Aug 25, 2020 at 07:44:03PM +0800, Yu Kuai wrote: > If sun8i_r40_tcon_tv_set_mux() succeed, at_dma_xlate() doesn't have a > corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. >=20 > Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") > Signed-off-by: Yu Kuai That doesn't sound right, we're not using at_dma_xlate at all in that driver? Maxime