From: Andi Kleen <ak@linux.intel.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
npiggin@suse.de, agl@us.ibm.com, nacc@us.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: Fix a race between hugetlb sysctl handlers
Date: Tue, 25 Aug 2020 08:25:09 -0700 [thread overview]
Message-ID: <20200825152509.GO1509399@tassilo.jf.intel.com> (raw)
In-Reply-To: <20200822095328.61306-1-songmuchun@bytedance.com>
> Fixes: e5ff215941d5 ("hugetlb: multiple hstates for multiple page sizes")
I don't think the Fixes line is correct. The original patch
just used a global variable and didn't have this race.
It must have been added later in some other patch that added
hugetlb_sysctl_handler_common.
-Andi
next prev parent reply other threads:[~2020-08-25 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 9:53 [PATCH] mm/hugetlb: Fix a race between hugetlb sysctl handlers Muchun Song
2020-08-24 20:59 ` Andrew Morton
2020-08-24 21:19 ` Mike Kravetz
2020-08-25 3:01 ` [External] " Muchun Song
2020-08-26 0:01 ` Mike Kravetz
2020-08-26 2:47 ` Muchun Song
2020-08-27 21:51 ` Mike Kravetz
2020-08-28 2:33 ` Muchun Song
2020-08-25 2:42 ` Muchun Song
2020-08-25 15:25 ` Andi Kleen [this message]
2020-08-26 2:34 ` [Phishing Risk] [External] " Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825152509.GO1509399@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nacc@us.ibm.com \
--cc=npiggin@suse.de \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).