From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BDBC433DF for ; Wed, 26 Aug 2020 09:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A79EE20897 for ; Wed, 26 Aug 2020 09:39:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QHJKMOnZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728269AbgHZJjQ (ORCPT ); Wed, 26 Aug 2020 05:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728282AbgHZJe3 (ORCPT ); Wed, 26 Aug 2020 05:34:29 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F55EC0617BF for ; Wed, 26 Aug 2020 02:34:19 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o21so1080639wmc.0 for ; Wed, 26 Aug 2020 02:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=QHJKMOnZ4tO+oPpdZO1XclI2udxtKXtC1n+sqUbOkrkLwibykUsRORT51V6Hkmmgh/ t2XgThhanyCXXUkHdhqimUKMlX98ujIdPf048s1aR3v7hgOP3/8q7x/nJ8HBBGos6wf8 lSorCwKC8Zxsxlntp2BNMFDaeK0yCVuJD9uU7Uo7WOoeNbsJRrDgCyd5OmboxWIMY+b+ ULLaynAuXVhaNpZirlsqEfKY/DHuk8Qzqjwm4x84UNsBiHXJPjegYxVr+KnAjZFTTFW3 Zk8AF2IVK+2d7F/ED6AGsvg9yf18ULdammO9EEvq9dfHEq7n6Vt5AIRLCwep9X2DZRiD E6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lOqkWcILbsAeyAfZ0GfzIi50eF5PW2PXQFze4naQS2g=; b=nlLAzonnonbIIMFvoRpw8lQtY+/mJ9sUHKPwbWOmMKYDHwKDLv4LnAsnmnUgWH5P8j rK2RlQdSlyyuECxxto/gb5gAAeJW90ROJs/euloKr4gbgXcMU03xSndrkrV+b/Nd26C3 EHAdad8jvpZ+ic0FqkNK9Or7V5FFk+GWGlkcOJYyhCNnUcA/2HtDGhUz+0Ze2+vPSss2 JqT6r2Tw6ZBnJBshgmRu4EnPaMsIzF5h6g5ruYNm+UQlAOUF2l76zkqQ/41zZeOePSKH buwa9ueNVxH033/J9hS4HJ7LMII/Gzj7HpEVfrjZYJvUMes0VQQ89072mgWvyfKxWn3j mfBA== X-Gm-Message-State: AOAM531GDY6MwGf/Ez6o1tTvQoYWfxVM+Vlo0DrzMfDj+R96m+5H/qmF KOFgVjimvLQG1Mb5QuLOWVUssXzwjAwxkQ== X-Google-Smtp-Source: ABdhPJwqg8QiNz57jChEdqZYRe6J78RNXFsyTh7fDBKnWvE8IIP9LARAxLgVs6l6Y3kheEFiyzHjtA== X-Received: by 2002:a1c:cc05:: with SMTP id h5mr5870886wmb.129.1598434457697; Wed, 26 Aug 2020 02:34:17 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:17 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Daniel Drake , Ulrich Kunitz , Michael Wu , "Luis R. Rodriguez" Subject: [PATCH 10/30] wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function documentation Date: Wed, 26 Aug 2020 10:33:41 +0100 Message-Id: <20200826093401.1458456-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200826093401.1458456-1-lee.jones@linaro.org> References: <20200826093401.1458456-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'hw' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'skb' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Function parameter or member 'tx_status' not described in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:433: warning: Excess function parameter 'flags' description in 'zd_mac_tx_status' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Function parameter or member 'urb' not described in 'zd_mac_tx_failed' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:487: warning: Excess function parameter 'dev' description in 'zd_mac_tx_failed' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Function parameter or member 'hw' not described in 'zd_op_tx' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:927: warning: Excess function parameter 'dev' description in 'zd_op_tx' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Function parameter or member 'hw' not described in 'filter_ack' drivers/net/wireless/zydas/zd1211rw/zd_mac.c:963: warning: Excess function parameter 'dev' description in 'filter_ack' Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Wu Cc: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c index a9999d10ae81f..3ef8533205f91 100644 --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c @@ -416,11 +416,10 @@ int zd_restore_settings(struct zd_mac *mac) /** * zd_mac_tx_status - reports tx status of a packet if required - * @hw - a &struct ieee80211_hw pointer - * @skb - a sk-buffer - * @flags: extra flags to set in the TX status info + * @hw: a &struct ieee80211_hw pointer + * @skb: a sk-buffer * @ackssi: ACK signal strength - * @success - True for successful transmission of the frame + * @tx_status: success and/or retry * * This information calls ieee80211_tx_status_irqsafe() if required by the * control information. It copies the control information into the status @@ -477,7 +476,7 @@ static void zd_mac_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb, /** * zd_mac_tx_failed - callback for failed frames - * @dev: the mac80211 wireless device + * @urb: pointer to the urb structure * * This function is called if a frame couldn't be successfully * transferred. The first frame from the tx queue, will be selected and @@ -913,9 +912,9 @@ static int fill_ctrlset(struct zd_mac *mac, /** * zd_op_tx - transmits a network frame to the device * - * @dev: mac80211 hardware device - * @skb: socket buffer + * @hw: a &struct ieee80211_hw pointer * @control: the control structure + * @skb: socket buffer * * This function transmit an IEEE 802.11 network frame to the device. The * control block of the skbuff will be initialized. If necessary the incoming @@ -946,7 +945,7 @@ static void zd_op_tx(struct ieee80211_hw *hw, /** * filter_ack - filters incoming packets for acknowledgements - * @dev: the mac80211 device + * @hw: a &struct ieee80211_hw pointer * @rx_hdr: received header * @stats: the status for the received packet * -- 2.25.1