From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: consider devices with of_match_table during i2c device probing
Date: Wed, 26 Aug 2020 12:53:56 +0300 [thread overview]
Message-ID: <20200826095356.GG1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200826052544.GA500@jagdpanzerIV.localdomain>
On Wed, Aug 26, 2020 at 02:25:44PM +0900, Sergey Senozhatsky wrote:
> On (20/08/26 07:08), Wolfram Sang wrote:
> > On Wed, Aug 26, 2020 at 01:29:37PM +0900, Sergey Senozhatsky wrote:
> > > Unlike acpi_match_device(), acpi_driver_match_device() does
> > > consider devices that provide of_match_table and performs
> > > of_compatible() matching for such devices. The key point here is
> > > that ACPI of_compatible() matching - acpi_of_match_device() - is
> > > part of ACPI and does not depend on CONFIG_OF.
> > >
> > > Consider the following case:
> > > o !CONFIG_OF system
> > > o probing of i2c device that provides .of_match_table, but no .id_table
> > >
> > > i2c_device_probe()
> > > ...
> > > if (!driver->id_table &&
> > > !i2c_acpi_match_device(dev->driver->acpi_match_table, client) &&
> > > !i2c_of_match_device(dev->driver->of_match_table, client)) {
> > > status = -ENODEV;
> > > goto put_sync_adapter;
> > > }
> > >
> > > i2c_of_match_device() depends on CONFIG_OF and, thus, is always false.
> > > i2c_acpi_match_device() does ACPI match only, no of_comtatible() matching
> > > takes place, even though the device provides .of_match_table and ACPI,
> > > technically, is capable of matching such device. The result is -ENODEV.
> > > Probing will succeed, however, if we'd use .of_match_table aware ACPI
> > > matching.
Looks like you read same StackOverflow question :-)
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> >
> > We have currently this in for-current which is even removing
> > i2c_acpi_match_device():
> >
> > http://patchwork.ozlabs.org/project/linux-i2c/list/?series=196990&state=*
>
> Oh, nice!
> Can we go a bit further and use i2c_device_match() in i2c_device_probe()
> instead of a mix of APIs from different subsystems?
> E.g.
>
> if (!driver->id_table &&
> - !i2c_acpi_match_device(dev->driver->acpi_match_table, client) &&
> - !i2c_of_match_device(dev->driver->of_match_table, client)) {
> + !(client && i2c_device_match(&client->dev, dev->driver))) {
You probably meant simply:
if (!i2c_device_match(dev, dev->driver)) {
> status = -ENODEV;
> goto put_sync_adapter;
> }
On the first glance it will work the same way but slightly longer in case of ID
table matching.
Send a patch!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-26 9:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 4:29 [PATCH 1/2] i2c: consider devices with of_match_table during i2c device probing Sergey Senozhatsky
2020-08-26 4:29 ` [PATCH 2/2] i2c: do not export i2c_of_match_device() symbol Sergey Senozhatsky
2020-08-26 5:07 ` [PATCH 1/2] i2c: consider devices with of_match_table during i2c device probing Sergey Senozhatsky
2020-08-26 5:08 ` Wolfram Sang
2020-08-26 5:25 ` Sergey Senozhatsky
2020-08-26 9:53 ` Andy Shevchenko [this message]
2020-08-26 9:56 ` Andy Shevchenko
2020-08-26 10:24 ` Sergey Senozhatsky
2020-08-26 10:38 ` Sergey Senozhatsky
2020-08-26 10:54 ` Andy Shevchenko
2020-08-26 11:23 ` Wolfram Sang
2020-08-26 14:18 ` Sergey Senozhatsky
2020-08-26 14:34 ` Andy Shevchenko
2020-08-26 14:50 ` Sergey Senozhatsky
2020-08-26 10:09 ` Sergey Senozhatsky
2020-08-26 7:19 ` kernel test robot
2020-08-26 12:38 ` kernel test robot
2020-08-26 12:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826095356.GG1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).