From: Jiri Olsa <jolsa@redhat.com>
To: Remi Bernon <rbernon@codeweavers.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jacek Caban <jacek@codeweavers.com>
Subject: Re: [PATCH v3 1/3] perf dso: Use libbfd to read build_id and .gnu_debuglink section
Date: Wed, 26 Aug 2020 13:47:13 +0200 [thread overview]
Message-ID: <20200826114713.GD753783@krava> (raw)
In-Reply-To: <20200821165238.1340315-1-rbernon@codeweavers.com>
On Fri, Aug 21, 2020 at 06:52:36PM +0200, Remi Bernon wrote:
> Wine generates PE binaries for most of its modules and perf is unable
> to parse these files to get build_id or .gnu_debuglink section.
>
> Using libbfd when available, instead of libelf, makes it possible to
> resolve debug file location regardless of the dso binary format.
>
> Signed-off-by: Remi Bernon <rbernon@codeweavers.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Jacek Caban <jacek@codeweavers.com>
> ---
>
> v3: Rebase and small changes to PATCH 2/3 and and PATCH 3/3.
all 3 patches look ok to me especially since I found out the new
code for loading symbols is for non ELF objects only ;-)
it'd be great if somebody with libbfd skills could review this,
but for me it looks ok.. for patchset:
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
>
> tools/perf/util/symbol-elf.c | 80 ++++++++++++++++++++++++++++++++++--
> 1 file changed, 77 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> index 8cc4b0059fb0..f7432c4a4154 100644
> --- a/tools/perf/util/symbol-elf.c
> +++ b/tools/perf/util/symbol-elf.c
> @@ -50,6 +50,10 @@ typedef Elf64_Nhdr GElf_Nhdr;
> #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */
> #endif
>
> +#ifdef HAVE_LIBBFD_SUPPORT
> +#define PACKAGE 'perf'
> +#include <bfd.h>
> +#else
> #ifdef HAVE_CPLUS_DEMANGLE_SUPPORT
> extern char *cplus_demangle(const char *, int);
>
> @@ -65,9 +69,7 @@ static inline char *bfd_demangle(void __maybe_unused *v,
> {
> return NULL;
> }
> -#else
> -#define PACKAGE 'perf'
> -#include <bfd.h>
> +#endif
> #endif
> #endif
>
> @@ -530,6 +532,36 @@ static int elf_read_build_id(Elf *elf, void *bf, size_t size)
> return err;
> }
>
> +#ifdef HAVE_LIBBFD_SUPPORT
> +
> +int filename__read_build_id(const char *filename, void *bf, size_t size)
> +{
> + int err = -1;
> + bfd *abfd;
> +
> + abfd = bfd_openr(filename, NULL);
> + if (!abfd)
> + return -1;
> +
> + if (!bfd_check_format(abfd, bfd_object)) {
> + pr_debug2("%s: cannot read %s bfd file.\n", __func__, filename);
> + goto out_close;
> + }
> +
> + if (!abfd->build_id || abfd->build_id->size > size)
> + goto out_close;
> +
> + memcpy(bf, abfd->build_id->data, abfd->build_id->size);
> + memset(bf + abfd->build_id->size, 0, size - abfd->build_id->size);
> + err = abfd->build_id->size;
> +
> +out_close:
> + bfd_close(abfd);
> + return err;
> +}
> +
> +#else
> +
> int filename__read_build_id(const char *filename, void *bf, size_t size)
> {
> int fd, err = -1;
> @@ -557,6 +589,8 @@ int filename__read_build_id(const char *filename, void *bf, size_t size)
> return err;
> }
>
> +#endif
> +
> int sysfs__read_build_id(const char *filename, void *build_id, size_t size)
> {
> int fd, err = -1;
> @@ -608,6 +642,44 @@ int sysfs__read_build_id(const char *filename, void *build_id, size_t size)
> return err;
> }
>
> +#ifdef HAVE_LIBBFD_SUPPORT
> +
> +int filename__read_debuglink(const char *filename, char *debuglink,
> + size_t size)
> +{
> + int err = -1;
> + asection *section;
> + bfd *abfd;
> +
> + abfd = bfd_openr(filename, NULL);
> + if (!abfd)
> + return -1;
> +
> + if (!bfd_check_format(abfd, bfd_object)) {
> + pr_debug2("%s: cannot read %s bfd file.\n", __func__, filename);
> + goto out_close;
> + }
> +
> + section = bfd_get_section_by_name(abfd, ".gnu_debuglink");
> + if (!section)
> + goto out_close;
> +
> + if (section->size > size)
> + goto out_close;
> +
> + if (!bfd_get_section_contents(abfd, section, debuglink, 0,
> + section->size))
> + goto out_close;
> +
> + err = 0;
> +
> +out_close:
> + bfd_close(abfd);
> + return err;
> +}
> +
> +#else
> +
> int filename__read_debuglink(const char *filename, char *debuglink,
> size_t size)
> {
> @@ -660,6 +732,8 @@ int filename__read_debuglink(const char *filename, char *debuglink,
> return err;
> }
>
> +#endif
> +
> static int dso__swap_init(struct dso *dso, unsigned char eidata)
> {
> static unsigned int const endian = 1;
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-08-26 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 16:52 [PATCH v3 1/3] perf dso: Use libbfd to read build_id and .gnu_debuglink section Remi Bernon
2020-08-21 16:52 ` [PATCH v3 2/3] perf symbols: Try reading the symbol table with libbfd Remi Bernon
2020-08-21 16:52 ` [PATCH v3 3/3] perf tests: Add test for PE binary format support Remi Bernon
2020-08-26 11:47 ` Jiri Olsa [this message]
2020-09-03 0:25 ` [PATCH v3 1/3] perf dso: Use libbfd to read build_id and .gnu_debuglink section Arnaldo Carvalho de Melo
2020-09-03 16:51 ` Arnaldo Carvalho de Melo
2020-09-04 7:57 ` Remi Bernon
2020-09-04 19:03 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826114713.GD753783@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jacek@codeweavers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rbernon@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).