From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, morten.rasmussen@arm.com
Subject: Re: [PATCH 1/2] sched/topology: Move sd_flag_debug out of linux/sched/topology.h
Date: Wed, 26 Aug 2020 17:25:50 +0300 [thread overview]
Message-ID: <20200826142550.GP1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200825133216.9163-1-valentin.schneider@arm.com>
On Tue, Aug 25, 2020 at 02:32:15PM +0100, Valentin Schneider wrote:
> Defining an array in a header imported all over the place clearly is a daft
> idea, that still didn't stop me from doing it.
>
> Leave a declaration of sd_flag_debug in topology.h and move its definition
> to sched/debug.c.
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: b6e862f38672 ("sched/topology: Define and assign sched_domain flag metadata")
> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> ---
> include/linux/sched/topology.h | 9 ++++-----
> kernel/sched/debug.c | 6 ++++++
> 2 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h
> index 2d59ca77103e..b9b0dab4d067 100644
> --- a/include/linux/sched/topology.h
> +++ b/include/linux/sched/topology.h
> @@ -33,14 +33,13 @@ static const unsigned int SD_DEGENERATE_GROUPS_MASK =
> #undef SD_FLAG
>
> #ifdef CONFIG_SCHED_DEBUG
> -#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
> -static const struct {
> +
> +struct sd_flag_debug {
> unsigned int meta_flags;
> char *name;
> -} sd_flag_debug[] = {
> -#include <linux/sched/sd_flags.h>
> };
> -#undef SD_FLAG
> +extern const struct sd_flag_debug sd_flag_debug[];
> +
> #endif
>
> #ifdef CONFIG_SCHED_SMT
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index 0655524700d2..0d7896d2a0b2 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -245,6 +245,12 @@ set_table_entry(struct ctl_table *entry,
> entry->proc_handler = proc_handler;
> }
>
> +#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
> +const struct sd_flag_debug sd_flag_debug[] = {
> +#include <linux/sched/sd_flags.h>
> +};
> +#undef SD_FLAG
> +
> static int sd_ctl_doflags(struct ctl_table *table, int write,
> void *buffer, size_t *lenp, loff_t *ppos)
> {
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-26 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 13:32 [PATCH 1/2] sched/topology: Move sd_flag_debug out of linux/sched/topology.h Valentin Schneider
2020-08-25 13:32 ` [PATCH 2/2] sched/topology: Move SD_DEGENERATE_GROUPS_MASK " Valentin Schneider
2020-08-26 14:24 ` Andy Shevchenko
2020-08-27 7:54 ` [tip: sched/core] " tip-bot2 for Valentin Schneider
2020-08-26 14:25 ` Andy Shevchenko [this message]
2020-08-27 7:54 ` [tip: sched/core] sched/topology: Move sd_flag_debug " tip-bot2 for Valentin Schneider
2020-08-27 8:50 ` Andy Shevchenko
2020-08-27 9:27 ` peterz
2020-08-27 9:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826142550.GP1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).