From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Alex Dewar <alex.dewar90@gmail.com>,
dennis.dalessandro@intel.com, dledford@redhat.com,
gustavo@embeddedor.com, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, mike.marciniszyn@intel.com,
roland@purestorage.com
Subject: Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements
Date: Wed, 26 Aug 2020 20:41:20 -0500 [thread overview]
Message-ID: <20200827014120.GD2671@embeddedor> (raw)
In-Reply-To: <20200827001149.GK24045@ziepe.ca>
On Wed, Aug 26, 2020 at 09:11:49PM -0300, Jason Gunthorpe wrote:
> On Wed, Aug 26, 2020 at 02:18:59PM -0500, Gustavo A. R. Silva wrote:
> > Hi,
> >
> > On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote:
> > > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote:
> > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> > > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which
> > > > were later converted to fallthrough statements by commit df561f6688fe
> > > > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity
> > > > warning about unreachable code.
> > > >
> > >
> > > It's worth mentioning that this warning is triggered only by compilers
> > > that don't support __attribute__((__fallthrough__)), which has been
> > > supported since GCC 7.1.
> > >
> > > > Remove the fallthrough statements.
> > > >
> > > > Addresses-Coverity: ("Unreachable code")
> > > > Fixes: 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> > > > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> > >
> > > Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > >
> >
> > I can take this in my tree for 5.9-rc3.
>
> That would make conflicts for the 2nd patch, lets just send them all
> through the rdma tree please.
OK.
> Is there a reason this is -rc material?
It's just that this warning is currently in mainline.
Thanks
--
Gustavo
next prev parent reply other threads:[~2020-08-27 1:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:51 [PATCH] IB/qib: remove superfluous fallthrough statements Alex Dewar
2020-08-25 16:19 ` Gustavo A. R. Silva
2020-08-25 16:26 ` Joe Perches
2020-08-25 16:49 ` Gustavo A. R. Silva
2020-08-25 16:47 ` Joe Perches
2020-08-25 17:01 ` Gustavo A. R. Silva
2020-08-25 20:55 ` Joe Perches
2020-08-25 16:58 ` Alex Dewar
2020-08-25 17:12 ` [PATCH v2 1/2] " Alex Dewar
2020-08-25 19:33 ` Gustavo A. R. Silva
2020-08-26 19:18 ` Gustavo A. R. Silva
2020-08-27 0:11 ` Jason Gunthorpe
2020-08-27 1:41 ` Gustavo A. R. Silva [this message]
2020-08-27 10:40 ` Alex Dewar
2020-08-31 16:25 ` Jason Gunthorpe
2020-08-25 17:12 ` [PATCH v2 2/2] IB/qib: tidy up process_cc() Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827014120.GD2671@embeddedor \
--to=gustavoars@kernel.org \
--cc=alex.dewar90@gmail.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).