From: Greg KH <gregkh@linuxfoundation.org>
To: Mrinal Pandey <mrinalmni@gmail.com>
Cc: skhan@linuxfoundation.org,
Linux-kernel-mentees@lists.linuxfoundation.org,
lukas.bulwahn@gmail.com, keescook@chromium.org,
re.emese@gmail.com, maennich@google.com, tglx@linutronix.de,
akpm@linux-foundation.org, kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, linux-spdx@vger.kernel.org
Subject: Re: [PATCH] scripts: Add intended executable mode and SPDX license
Date: Thu, 27 Aug 2020 11:43:44 +0200 [thread overview]
Message-ID: <20200827094344.GA400189@kroah.com> (raw)
In-Reply-To: <20200827092405.b6hymjxufn2nvgml@mrinalpandey>
On Thu, Aug 27, 2020 at 02:54:05PM +0530, Mrinal Pandey wrote:
> commit b72231eb7084 ("scripts: add spdxcheck.py self test") added the file
> spdxcheck-test.sh to the repository without the executable flag and license
> information.
>
> commit eb8305aecb95 ("scripts: Coccinelle script for namespace
> dependencies.") added the file nsdeps, commit 313dd1b62921 ("gcc-plugins:
> Add the randstruct plugin") added the file gcc-plugins/gen-random-seed.sh
> and commit 9b4ade226f74 ("xen: build infrastructure for generating
> hypercall depending symbols") added the file xen-hypercalls.sh without the
> executable bit.
>
> Set to usual modes for these files and provide the SPDX license for
> spdxcheck-test.sh. No functional changes.
>
> Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com>
> ---
> applies cleanly on next-20200827
>
> Kees, Matthias, Thomas, please ack this patch.
>
> Andrew, please pick this minor non-urgent cleanup patch once the
> mainainers ack.
>
> scripts/gcc-plugins/gen-random-seed.sh | 0
> scripts/nsdeps | 0
> scripts/spdxcheck-test.sh | 1 +
> scripts/xen-hypercalls.sh | 0
> 4 files changed, 1 insertion(+)
> mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh
> mode change 100644 => 100755 scripts/nsdeps
> mode change 100644 => 100755 scripts/spdxcheck-test.sh
> mode change 100644 => 100755 scripts/xen-hypercalls.sh
This does 2 different things in one patch, shouldn't this be 2 different
patches? One to change the permissions and one to add the SPDX line?
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-27 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 9:24 [PATCH] scripts: Add intended executable mode and SPDX license Mrinal Pandey
2020-08-27 9:34 ` Lukas Bulwahn
2020-08-27 9:43 ` Greg KH [this message]
2020-08-27 9:49 ` Lukas Bulwahn
2020-08-27 10:00 ` Greg KH
2020-08-27 18:14 ` Kees Cook
2020-08-31 0:44 ` Andrew Morton
2020-08-31 5:45 ` Lukas Bulwahn
2020-08-31 19:20 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827094344.GA400189@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Linux-kernel-mentees@lists.linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maennich@google.com \
--cc=mrinalmni@gmail.com \
--cc=re.emese@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).