From: Borislav Petkov <bp@alien8.de>
To: Alison Wang <alison.wang@nxp.com>
Cc: James Morse <james.morse@arm.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"rrichter@marvell.com" <rrichter@marvell.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores
Date: Thu, 27 Aug 2020 12:40:00 +0200 [thread overview]
Message-ID: <20200827104000.GB30897@zn.tnic> (raw)
In-Reply-To: <VI1PR04MB4062B4701339466752BFDDE9F4540@VI1PR04MB4062.eurprd04.prod.outlook.com>
On Wed, Aug 26, 2020 at 03:03:15AM +0000, Alison Wang wrote:
> [Alison] I have a look at this patch. This patch doesn't complete all
> the functions in my patch.
Yep, but pls work together to see if a single driver can support your hw
too.
> It is just to report errors, but error injection function is all
> removed.
Right, because you can't use that on this hw, apparently.
Also note that you should disable error injection in production for
obvious reasons. Thus all the error injection stuff in EDAC is behind
CONFIG_EDAC_DEBUG which should be off in production kernels.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-08-27 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 8:22 [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores Alison Wang
2020-08-15 8:41 ` Borislav Petkov
2020-08-21 11:38 ` James Morse
2020-08-25 2:31 ` [EXT] " Alison Wang
2020-08-25 13:18 ` James Morse
2020-08-26 3:03 ` Alison Wang
2020-08-27 10:40 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827104000.GB30897@zn.tnic \
--to=bp@alien8.de \
--cc=alison.wang@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).