From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A437C433E1 for ; Thu, 27 Aug 2020 13:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F05B206F0 for ; Thu, 27 Aug 2020 13:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598533533; bh=y/lp9qyaaM7Bpx+/gb8wqjGJ5T/lQhnVCnSMOeuYfec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=gsGqAVrow/QcfSRUhDSPs15aOegtwUZ/b1OAilQnvavhDBvsIwbTsYMsmlRYmFpGk aaJBDkaIU6+m3nOisANS4yeZKtYqTHr6xQK/AXr3luBxDMRV9wCcUusUOeZxq8hA9y klKuv24AfPfhDukKjCy0VKIeHGO7wD3W/NISASyQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbgH0NF0 (ORCPT ); Thu, 27 Aug 2020 09:05:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:44300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbgH0NE7 (ORCPT ); Thu, 27 Aug 2020 09:04:59 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 599CD22CAF; Thu, 27 Aug 2020 13:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598533381; bh=y/lp9qyaaM7Bpx+/gb8wqjGJ5T/lQhnVCnSMOeuYfec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U4je+28DrKs6l2GyNXB1ys9+ccco2w261d7RE1Vl8JuZ/56fFCHHV0q5WApIvhWXz OUxmf/ltt8gsBFjbuogwRYMvlSDrAfam0HzbNjIKbTLZoeie5CV61Acmp+KjMo12TV nIi07CTolp4VkXD2kQbGeKT1tFn5byQJybruDHRo= Date: Thu, 27 Aug 2020 22:02:56 +0900 From: Masami Hiramatsu To: peterz@infradead.org Cc: linux-kernel@vger.kernel.org, Eddy Wu , x86@kernel.org, "David S . Miller" , Steven Rostedt , Ingo Molnar , "Naveen N . Rao" , Anil S Keshavamurthy , linux-arch@vger.kernel.org Subject: Re: [PATCH v2 15/15] kprobes: Free kretprobe_instance with rcu callback Message-Id: <20200827220256.9aaedd03e3eeec8d7b765132@kernel.org> In-Reply-To: <20200827114919.GB2674@hirez.programming.kicks-ass.net> References: <159852811819.707944.12798182250041968537.stgit@devnote2> <159852826969.707944.15092569392287597887.stgit@devnote2> <20200827114919.GB2674@hirez.programming.kicks-ass.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Aug 2020 13:49:19 +0200 peterz@infradead.org wrote: > On Thu, Aug 27, 2020 at 08:37:49PM +0900, Masami Hiramatsu wrote: > > > +void recycle_rp_inst(struct kretprobe_instance *ri) > > Also note, that at this point there is no external caller of this > function anymore. OK, actually, there are more local functions are exported without any reason. Let's make all static. Thank you, -- Masami Hiramatsu