From: kernel test robot <lkp@intel.com>
To: Chunguang Xu <brookxu.cn@gmail.com>, arnd@arndb.de
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
rppt@kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code
Date: Fri, 28 Aug 2020 14:05:41 +0800 [thread overview]
Message-ID: <202008281301.jJapNJEm%lkp@intel.com> (raw)
In-Reply-To: <5e7c145a8b5a57c78b9228806738ccb0cfc2ac98.1598518912.git.brookxu@tencent.com>
[-- Attachment #1: Type: text/plain, Size: 17090 bytes --]
Hi Chunguang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next linus/master asm-generic/master v5.9-rc2 next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-randconfig-a015-20200827 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 71f3169e1baeff262583b35ef88f8fb6df7be85e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> net/rxrpc/af_rxrpc.c:226:3: error: use of undeclared identifier 'x'
ASSERT(rx->local != NULL);
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/af_rxrpc.c:226:3: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> net/rxrpc/call_accept.c:479:2: error: use of undeclared identifier 'x'
ASSERT(!irqs_disabled());
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/call_accept.c:479:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/call_accept.c:602:2: error: use of undeclared identifier 'x'
ASSERT(!irqs_disabled());
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/call_accept.c:602:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
4 errors generated.
--
>> net/rxrpc/call_event.c:177:2: error: use of undeclared identifier 'x'
ASSERT(before_eq(cursor, top));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/call_event.c:177:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> net/rxrpc/call_object.c:555:2: error: use of undeclared identifier 'x'
ASSERT(call != NULL);
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/call_object.c:555:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/call_object.c:619:2: error: use of undeclared identifier 'x'
ASSERT(test_bit(RXRPC_CALL_RELEASED, &call->flags));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/call_object.c:619:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
4 errors generated.
--
>> net/rxrpc/conn_client.c:811:3: error: use of undeclared identifier 'x'
ASSERT(!test_bit(RXRPC_CALL_EXPOSED, &call->flags));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/conn_client.c:811:3: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_client.c:901:3: error: use of undeclared identifier 'x'
ASSERT(list_empty(&conn->waiting_calls));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_client.c:901:3: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_client.c:1034:3: error: use of undeclared identifier 'x'
ASSERT(!list_empty(&rxnet->active_client_conns));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_client.c:1034:3: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_client.c:1101:2: error: use of undeclared identifier 'x'
ASSERT(test_bit(RXRPC_CONN_EXPOSED, &conn->flags));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_client.c:1101:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
8 errors generated.
--
>> net/rxrpc/conn_event.c:377:2: error: use of undeclared identifier 'x'
ASSERT(conn->security_ix != 0);
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/conn_event.c:377:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_event.c:378:2: error: use of undeclared identifier 'x'
ASSERT(conn->server_key);
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_event.c:378:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
4 errors generated.
--
>> net/rxrpc/conn_object.c:239:2: error: use of undeclared identifier 'x'
ASSERT(!rcu_access_pointer(conn->channels[0].call) &&
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/conn_object.c:239:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_object.c:243:2: error: use of undeclared identifier 'x'
ASSERT(list_empty(&conn->cache_link));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_object.c:243:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_object.c:438:3: error: use of undeclared identifier 'x'
ASSERT(time_after(earliest, now));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_object.c:438:3: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_object.c:481:2: error: use of undeclared identifier 'x'
ASSERT(list_empty(&rxnet->conn_proc_list));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/conn_object.c:481:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
8 errors generated.
--
>> net/rxrpc/input.c:262:2: error: use of undeclared identifier 'x'
ASSERT(test_bit(RXRPC_CALL_TX_LAST, &call->flags));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/input.c:262:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> net/rxrpc/local_object.c:401:2: error: use of undeclared identifier 'x'
ASSERT(!local->service);
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/local_object.c:401:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/local_object.c:462:2: error: use of undeclared identifier 'x'
ASSERT(!work_pending(&local->processor));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
net/rxrpc/local_object.c:462:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
4 errors generated.
--
>> net/rxrpc/peer_event.c:397:2: error: use of undeclared identifier 'x'
ASSERT(list_empty(&collector));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/peer_event.c:397:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> net/rxrpc/peer_object.c:416:2: error: use of undeclared identifier 'x'
ASSERT(hlist_empty(&peer->error_targets));
^
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
>> net/rxrpc/peer_object.c:416:2: error: use of undeclared identifier 'x'
net/rxrpc/ar-internal.h:1184:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
..
# https://github.com/0day-ci/linux/commit/1d215ffa42c9e100fa23c485351acf9293936807
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
git checkout 1d215ffa42c9e100fa23c485351acf9293936807
vim +/x +226 net/rxrpc/af_rxrpc.c
17926a79320afa9 David Howells 2007-04-26 205
17926a79320afa9 David Howells 2007-04-26 206 /*
17926a79320afa9 David Howells 2007-04-26 207 * set the number of pending calls permitted on a listening socket
17926a79320afa9 David Howells 2007-04-26 208 */
17926a79320afa9 David Howells 2007-04-26 209 static int rxrpc_listen(struct socket *sock, int backlog)
17926a79320afa9 David Howells 2007-04-26 210 {
17926a79320afa9 David Howells 2007-04-26 211 struct sock *sk = sock->sk;
17926a79320afa9 David Howells 2007-04-26 212 struct rxrpc_sock *rx = rxrpc_sk(sk);
00e907127e6f86d David Howells 2016-09-08 213 unsigned int max, old;
17926a79320afa9 David Howells 2007-04-26 214 int ret;
17926a79320afa9 David Howells 2007-04-26 215
17926a79320afa9 David Howells 2007-04-26 216 _enter("%p,%d", rx, backlog);
17926a79320afa9 David Howells 2007-04-26 217
17926a79320afa9 David Howells 2007-04-26 218 lock_sock(&rx->sk);
17926a79320afa9 David Howells 2007-04-26 219
17926a79320afa9 David Howells 2007-04-26 220 switch (rx->sk.sk_state) {
2341e0775747864 David Howells 2016-06-09 221 case RXRPC_UNBOUND:
17926a79320afa9 David Howells 2007-04-26 222 ret = -EADDRNOTAVAIL;
17926a79320afa9 David Howells 2007-04-26 223 break;
17926a79320afa9 David Howells 2007-04-26 224 case RXRPC_SERVER_BOUND:
28036f44851e251 David Howells 2017-06-05 225 case RXRPC_SERVER_BOUND2:
17926a79320afa9 David Howells 2007-04-26 @226 ASSERT(rx->local != NULL);
0e119b41b7f23e0 David Howells 2016-06-10 227 max = READ_ONCE(rxrpc_max_backlog);
0e119b41b7f23e0 David Howells 2016-06-10 228 ret = -EINVAL;
0e119b41b7f23e0 David Howells 2016-06-10 229 if (backlog == INT_MAX)
0e119b41b7f23e0 David Howells 2016-06-10 230 backlog = max;
0e119b41b7f23e0 David Howells 2016-06-10 231 else if (backlog < 0 || backlog > max)
0e119b41b7f23e0 David Howells 2016-06-10 232 break;
00e907127e6f86d David Howells 2016-09-08 233 old = sk->sk_max_ack_backlog;
17926a79320afa9 David Howells 2007-04-26 234 sk->sk_max_ack_backlog = backlog;
00e907127e6f86d David Howells 2016-09-08 235 ret = rxrpc_service_prealloc(rx, GFP_KERNEL);
00e907127e6f86d David Howells 2016-09-08 236 if (ret == 0)
17926a79320afa9 David Howells 2007-04-26 237 rx->sk.sk_state = RXRPC_SERVER_LISTENING;
00e907127e6f86d David Howells 2016-09-08 238 else
00e907127e6f86d David Howells 2016-09-08 239 sk->sk_max_ack_backlog = old;
17926a79320afa9 David Howells 2007-04-26 240 break;
210f035316f545e David Howells 2017-01-05 241 case RXRPC_SERVER_LISTENING:
210f035316f545e David Howells 2017-01-05 242 if (backlog == 0) {
210f035316f545e David Howells 2017-01-05 243 rx->sk.sk_state = RXRPC_SERVER_LISTEN_DISABLED;
210f035316f545e David Howells 2017-01-05 244 sk->sk_max_ack_backlog = 0;
210f035316f545e David Howells 2017-01-05 245 rxrpc_discard_prealloc(rx);
210f035316f545e David Howells 2017-01-05 246 ret = 0;
210f035316f545e David Howells 2017-01-05 247 break;
210f035316f545e David Howells 2017-01-05 248 }
e3cf39706b89001 Gustavo A. R. Silva 2017-10-19 249 /* Fall through */
0e119b41b7f23e0 David Howells 2016-06-10 250 default:
0e119b41b7f23e0 David Howells 2016-06-10 251 ret = -EBUSY;
0e119b41b7f23e0 David Howells 2016-06-10 252 break;
17926a79320afa9 David Howells 2007-04-26 253 }
17926a79320afa9 David Howells 2007-04-26 254
17926a79320afa9 David Howells 2007-04-26 255 release_sock(&rx->sk);
17926a79320afa9 David Howells 2007-04-26 256 _leave(" = %d", ret);
17926a79320afa9 David Howells 2007-04-26 257 return ret;
17926a79320afa9 David Howells 2007-04-26 258 }
17926a79320afa9 David Howells 2007-04-26 259
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41472 bytes --]
next prev parent reply other threads:[~2020-08-28 6:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:14 [PATCH 00/23] clean up the code related to ASSERT() Chunguang Xu
2020-08-27 10:14 ` [PATCH 01/23] include/asm-generic/bug.h: add ASSERT_FAIL() and ASSERT_WARN() wrapper Chunguang Xu
2020-08-27 10:14 ` [PATCH 02/23] ia64: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code Chunguang Xu
2020-08-27 10:14 ` [PATCH 03/23] KVM: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 04/23] fore200e: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 05/23] scsi: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 06/23] rxrpc: " Chunguang Xu
2020-08-27 17:10 ` kernel test robot
2020-08-27 18:03 ` kernel test robot
2020-08-28 6:05 ` kernel test robot [this message]
2020-08-27 10:14 ` [PATCH 07/23] lib/mpi: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 08/23] jfs: " Chunguang Xu
2020-08-27 16:13 ` kernel test robot
2020-08-27 10:14 ` [PATCH 09/23] cachefiles: " Chunguang Xu
2020-08-28 4:30 ` kernel test robot
2020-08-27 10:14 ` [PATCH 10/23] btrfs: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 11/23] afs: " Chunguang Xu
2020-08-27 16:29 ` kernel test robot
2020-08-28 9:49 ` kernel test robot
2020-08-27 10:14 ` [PATCH 12/23] rivafb: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 13/23] nvidia: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 14/23] fbdev/cirrusfb:: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 15/23] media/staging: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 16/23] sym53c8xx: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 17/23] 8139too: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 18/23] net:hns: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 19/23] block/sx8: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 20/23] skb: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 21/23] ext4: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 22/23] rbd: " Chunguang Xu
2020-08-27 10:14 ` [PATCH 23/23] ALSA: asihpi: " Chunguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008281301.jJapNJEm%lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=brookxu.cn@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).