From: Rob Herring <robh@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
sboyd@kernel.org, gregkh@linuxfoundation.org,
mturquette@baylibre.com
Subject: Re: [PATCH v6 1/8] dt-bindings: add documentation of xilinx clocking wizard
Date: Fri, 28 Aug 2020 15:56:22 -0600 [thread overview]
Message-ID: <20200828215622.GA3469481@bogus> (raw)
In-Reply-To: <1598621996-31040-2-git-send-email-shubhrajyoti.datta@xilinx.com>
On Fri, Aug 28, 2020 at 07:09:49PM +0530, Shubhrajyoti Datta wrote:
> Add the devicetree binding for the xilinx clocking wizard.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> v6:
> Fix a yaml warning
>
> .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> new file mode 100644
> index 0000000..ca63593
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/xlnx,clocking-wizard.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xilinx clocking wizard
> +
> +maintainers:
> + - Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> +
> +description: |
> + The clocking wizard is a soft ip clocking block of Xilinx versal. It
> + reads required input clock frequencies from the devicetree and acts as clock
> + clock output.
> +
> +select: false
> +
> +properties:
> + compatible:
> + items:
> + - enum:
You can drop 'items' since there is only 1.
> + - xlnx,clocking-wizard
> + - xlnx,clocking-wizard-6.0
> +
> + "#clock-cells":
> + const: 1
> +
> + clocks:
> + description: List of clock specifiers which are external input
> + clocks to the given clock controller.
Drop this. That's every 'clocks' property.
> + items:
> + - description: clock input
> + - description: axi clock
> +
> + clock-names:
> + items:
> + - const: clk_in1
> + - const: s_axi_aclk
> +
> + speed-grade:
Needs a vendor prefix.
> + allOf:
You can remove the 'allOf'.
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - enum: [1, 2, 3]
> + description:
> + Speed grade of the device.
> + maxItems: 1
Drop this. A 'uint32' is always 1 item.
> +
> +required:
> + - compatible
> + - "#clock-cells"
> + - clocks
> + - clock-names
> + - speed-grade
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + clock-generator@40040000 {
> + #clock-cells = <1>;
> + reg = <0x40040000 0x1000>;
> + compatible = "xlnx,clk-wizard-1.0";
Doesn't match the schema.
> + speed-grade = <1>;
> + clock-names = "clk_in1", "s_axi_aclk";
> + clocks = <&clkc 15>, <&clkc 15>;
> + clock-output-names = "clk_out1", "clk_out2",
> + "clk_out3", "clk_out4", "clk_out5",
> + "clk_out6", "clk_out7";
> + };
> +...
> --
> 2.1.1
>
next prev parent reply other threads:[~2020-08-28 21:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 13:39 [PATCH v6 0/8] clk: clk-wizard: clock-wizard: Driver updates Shubhrajyoti Datta
2020-08-28 13:39 ` [PATCH v6 1/8] dt-bindings: add documentation of xilinx clocking wizard Shubhrajyoti Datta
2020-08-28 21:56 ` Rob Herring [this message]
2020-08-28 13:39 ` [PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory Shubhrajyoti Datta
2020-09-21 21:19 ` Stephen Boyd
2020-09-21 21:21 ` Stephen Boyd
2020-11-04 4:07 ` Shubhrajyoti Datta
2020-08-28 13:39 ` [PATCH v6 3/8] clk: clock-wizard: Fix kernel-doc warning Shubhrajyoti Datta
2020-08-28 13:39 ` [PATCH v6 4/8] clk: clock-wizard: Add support for dynamic reconfiguration Shubhrajyoti Datta
2020-09-21 21:26 ` Stephen Boyd
2020-08-28 13:39 ` [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support Shubhrajyoti Datta
2020-09-21 21:17 ` Stephen Boyd
2020-09-24 6:23 ` Shubhrajyoti Datta
2020-09-22 9:17 ` Dan Carpenter
2020-08-28 13:39 ` [PATCH v6 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs Shubhrajyoti Datta
2020-08-28 13:39 ` [PATCH v6 7/8] clk: clock-wizard: Update the fixed factor divisors Shubhrajyoti Datta
2020-08-28 13:39 ` [PATCH v6 8/8] staging: clocking-wizard: Delete the driver from the staging Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828215622.GA3469481@bogus \
--to=robh@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).