From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9A4C433E2 for ; Sat, 29 Aug 2020 12:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DC30207DA for ; Sat, 29 Aug 2020 12:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727940AbgH2MEk (ORCPT ); Sat, 29 Aug 2020 08:04:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:36252 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726876AbgH2ME3 (ORCPT ); Sat, 29 Aug 2020 08:04:29 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kBzab-0006OZ-Rb; Sat, 29 Aug 2020 22:04:10 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 29 Aug 2020 22:04:09 +1000 Date: Sat, 29 Aug 2020 22:04:09 +1000 From: Herbert Xu To: George Acosta Cc: "David S. Miller" , Christophe JAILLET , "Gustavo A. R. Silva" , Phani Kiran Hemadri , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions Message-ID: <20200829120409.GA22368@gondor.apana.org.au> References: <20200821031209.21279-1-acostag.ubuntu@gmail.com> <20200828071931.GB28064@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 28, 2020 at 08:53:36PM -0500, George Acosta wrote: > Hi Herbert, > I just noticed a small potential issue about the calling sequence of > pci_disable_device and dev_err. > Do you think it will be better to call dev_err before we call > pci_disable_device(pdev) , or the order here does not matter? I don't think it matters. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt