From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849D6C433E2 for ; Sun, 30 Aug 2020 10:14:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 637C3208CA for ; Sun, 30 Aug 2020 10:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598782486; bh=YtCnCHfNPMwebTaJNkKt9knUiwPTCg4dVZL7GaXUcRs=; h=From:To:Cc:Subject:Date:List-ID:From; b=jPdmWkkMsY3k7EbsT0hs6m8FMpQ9qarZiDVV9O8nGCvbaAPnwGciydKR7x+oyVWU7 VzZEqsHKJEmKUrEO8HqP2TxJdAO2T1Yl+4PK/wDxUjR3zv77c+0lkAobI2pAbe7Xie XF1obc3wpWydgBUzP6Jqzg/H39PylNBZMPRmg/qk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728760AbgH3KOp (ORCPT ); Sun, 30 Aug 2020 06:14:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbgH3KOn (ORCPT ); Sun, 30 Aug 2020 06:14:43 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52C5B2071B; Sun, 30 Aug 2020 10:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598782482; bh=YtCnCHfNPMwebTaJNkKt9knUiwPTCg4dVZL7GaXUcRs=; h=From:To:Cc:Subject:Date:From; b=yS1qmxARoUjaYoxGXtue6oEfs8u4bR66np2Avp9Yh7SESuwGx7W66zhn1L722rLC+ coUB8/6P7uz8qLZ80TXzK6cFL96hAt/ffUwbjPPbcuS2klCOMHFlRZO8dF96SO7PdB SmgVJ6HkwPb0CdzRDhNY/f6JjpnFpYhzeDivIBuM= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , Gal Pressman , Leon Romanovsky , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Zhang Subject: [PATCH rdma-next v1 00/13] Track memory allocation with restrack DB help Date: Sun, 30 Aug 2020 13:14:23 +0300 Message-Id: <20200830101436.108487-1-leon@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leon Romanovsky Changelog: v1: * Fixed rebase error, deleted second assignment of qp_type. * Rebased code on latests rdma-next, the changes in cma.c caused to change in patch "RDMA/cma: Delete from restrack DB after successful destroy". * Dropped patch of port assignment, it is already done as part of this series. * I didn't add @calller description, regular users should not use _named() funciton. v0: https://lore.kernel.org/lkml/20200824104415.1090901-1-leon@kernel.org ---------------------------------------------------------------------------------- Hi, The resource tracker has built-in kref counter to synchronize object release. It makes restrack perfect choice to be responsible for the memory lifetime of any object in which restrack entry is embedded. In order to make it, the restrack was changed to be mandatory and all callers of rdma_restrack_add() started to rely on result returned from that call. Being mandatory means that all objects specific to restrack type must be tracked. Before this series, the restrack and rdmatool were aid tools in debug session of user space applications, this caused to some of the functionality to be left behind, like support XRC QPs, device memory MRs and QP0/QP1 in multi-port devices. This series fixes all mentioned above without extending rdmatool at all. Thanks Leon Romanovsky (13): RDMA/cma: Delete from restrack DB after successful destroy RDMA/mlx5: Don't call to restrack recursively RDMA/restrack: Count references to the verbs objects RDMA/restrack: Simplify restrack tracking in kernel flows RDMA/restrack: Improve readability in task name management RDMA/cma: Be strict with attaching to CMA device RDMA/core: Allow drivers to disable restrack DB RDMA/counter: Combine allocation and bind logic RDMA/restrack: Store all special QPs in restrack DB RDMA/restrack: Make restrack DB mandatory for IB objects RDMA/restrack: Support all QP types RDMA/core: Track device memory MRs RDMA/restrack: Drop valid restrack field as source of ambiguity drivers/infiniband/core/cma.c | 225 +++++++++++------- drivers/infiniband/core/core_priv.h | 39 ++- drivers/infiniband/core/counters.c | 178 +++++++------- drivers/infiniband/core/cq.c | 24 +- drivers/infiniband/core/rdma_core.c | 3 +- drivers/infiniband/core/restrack.c | 208 ++++++++-------- drivers/infiniband/core/restrack.h | 10 +- drivers/infiniband/core/uverbs_cmd.c | 50 +++- drivers/infiniband/core/uverbs_std_types_cq.c | 12 +- drivers/infiniband/core/uverbs_std_types_mr.c | 10 + drivers/infiniband/core/uverbs_std_types_qp.c | 4 +- drivers/infiniband/core/verbs.c | 91 +++++-- drivers/infiniband/hw/mlx5/gsi.c | 16 +- drivers/infiniband/hw/mlx5/qp.c | 2 +- include/rdma/ib_verbs.h | 10 +- include/rdma/restrack.h | 46 ++-- 16 files changed, 537 insertions(+), 391 deletions(-) -- 2.26.2