From: Peter Chen <peter.chen@nxp.com>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"balbi@kernel.org" <balbi@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"agross@kernel.org" <agross@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"jackp@codeaurora.org" <jackp@codeaurora.org>
Subject: Re: [RFC v5 4/6] usb: gadget: configfs: Check USB configuration before adding
Date: Mon, 31 Aug 2020 02:29:48 +0000 [thread overview]
Message-ID: <20200831022825.GA15756@b29397-desktop> (raw)
In-Reply-To: <20200829055846.19034-5-wcheng@codeaurora.org>
On 20-08-28 22:58:44, Wesley Cheng wrote:
> Ensure that the USB gadget is able to support the configuration being
> added based on the number of endpoints required from all interfaces. This
> is for accounting for any bandwidth or space limitations.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> drivers/usb/gadget/configfs.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 56051bb97349..7c74c04b1d8c 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1361,6 +1361,7 @@ static int configfs_composite_bind(struct usb_gadget *gadget,
> struct usb_function *f;
> struct usb_function *tmp;
> struct gadget_config_name *cn;
> + unsigned long ep_map = 0;
>
> if (gadget_is_otg(gadget))
> c->descriptors = otg_desc;
> @@ -1390,7 +1391,28 @@ static int configfs_composite_bind(struct usb_gadget *gadget,
> list_add(&f->list, &cfg->func_list);
> goto err_purge_funcs;
> }
> + if (f->ss_descriptors) {
> + struct usb_descriptor_header **d;
> +
> + d = f->ss_descriptors;
> + for (; *d; ++d) {
> + struct usb_endpoint_descriptor *ep;
> + int addr;
> +
> + if ((*d)->bDescriptorType != USB_DT_ENDPOINT)
> + continue;
> +
> + ep = (struct usb_endpoint_descriptor *)*d;
> + addr = ((ep->bEndpointAddress & 0x80) >> 3) |
> + (ep->bEndpointAddress & 0x0f);
">> 3" or "<< 3?
> + set_bit(addr, &ep_map);
You want to record all endpoints on ep_map? Considering there are
four EP_IN (1-4), and four EP_OUT (1-4), what the value of ep_map
would like?
> + }
> + }
> }
> + ret = usb_gadget_check_config(cdev->gadget, ep_map);
> + if (ret)
> + goto err_purge_funcs;
> +
You may move this patch after your 4nd patch to avoid "git bisect"
issue.
> usb_ep_autoconfig_reset(cdev->gadget);
> }
> if (cdev->use_os_string) {
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2020-08-31 2:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 5:58 [RFC v5 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2020-08-29 5:58 ` [RFC v5 1/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2020-08-29 5:58 ` [RFC v5 2/6] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng
2020-08-29 5:58 ` [RFC v5 3/6] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize Wesley Cheng
2020-08-29 5:58 ` [RFC v5 4/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2020-08-31 2:29 ` Peter Chen [this message]
2020-08-31 7:34 ` Wesley Cheng
2020-08-29 5:58 ` [RFC v5 5/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2020-08-29 5:58 ` [RFC v5 6/6] usb: dwc3: gadget: Ensure enough TXFIFO space for " Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831022825.GA15756@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).