From: Al Viro <viro@zeniv.linux.org.uk>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Yuqi Jin <jinyuqi@huawei.com>,
kernel test robot <rong.a.chen@intel.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [NAK] Re: [PATCH] fs: Optimized fget to improve performance
Date: Mon, 31 Aug 2020 04:21:27 +0100 [thread overview]
Message-ID: <20200831032127.GW1236603@ZenIV.linux.org.uk> (raw)
In-Reply-To: <dfa0ec1a-87fc-b17b-4d4a-c2d5c44e6dde@hisilicon.com>
On Mon, Aug 31, 2020 at 09:43:31AM +0800, Shaokun Zhang wrote:
> How about this? We try to replace atomic_cmpxchg with atomic_add to improve
> performance. The atomic_add does not check the current f_count value.
> Therefore, the number of online CPUs is reserved to prevent multi-core
> competition.
No. Really, really - no. Not unless you can guarantee that process on another
CPU won't lose its timeslice, ending up with more than one increment happening on
the same CPU - done by different processes scheduled there, one after another.
If you have some change of atomic_long_add_unless(), do it there. And get it
past the arm64 folks. get_file_rcu() is nothing special in that respect *AND*
it has to cope with any architecture out there.
BTW, keep in mind that there's such thing as a KVM - race windows are much
wider there, since a thread representing a guest CPU might lose its timeslice
whenever the host feels like that. At which point you get a single instruction
on a guest CPU taking longer than many thousands of instructions on another
CPU of the same guest.
AFAIK, arm64 does support KVM with SMP guests.
next prev parent reply other threads:[~2020-08-31 3:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 10:19 [PATCH] fs: Optimized fget to improve performance Shaokun Zhang
2020-08-27 12:30 ` Matthew Wilcox
2020-08-27 13:07 ` David Laight
2020-08-27 14:28 ` [NAK] " Al Viro
2020-08-28 11:04 ` Will Deacon
2020-08-31 1:43 ` Shaokun Zhang
2020-08-31 3:21 ` Al Viro [this message]
2020-09-01 9:29 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831032127.GW1236603@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=boqun.feng@gmail.com \
--cc=jinyuqi@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=rong.a.chen@intel.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).