From: Vinod Koul <vkoul@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: kishon@ti.com, Tony Lindgren <tony@atomide.com>,
robh+dt@kernel.org, nsekhar@ti.com, vigneshr@ti.com,
jan.kiszka@siemens.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4] dt-binding: phy: convert ti,omap-usb2 to YAML
Date: Mon, 31 Aug 2020 16:41:33 +0530 [thread overview]
Message-ID: <20200831111133.GP2639@vkoul-mobl> (raw)
In-Reply-To: <a6a59fba-6a0c-c00f-29e7-e85c7dcc1319@ti.com>
On 24-08-20, 10:47, Roger Quadros wrote:
> Hi,
>
> On 21/08/2020 11:11, Roger Quadros wrote:
> > Move ti,omap-usb2 to its own YAML schema.
> >
> > Signed-off-by: Roger Quadros <rogerq@ti.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >
> > v4
> > - fix example to fix dt_binding_check warnings
> > - '#phy-cells' -> "#phy-cells"
> > - Add 'oneOf' to compatible logic to allow just "ti,omap-usb2" as valid
> >
> > v3
> > - Removed quotes from compatibles
> > - changed property to "ti,disable-charger-det"
> >
> > v2
> > - Address Rob's comments on YAML schema.
> >
> > .../devicetree/bindings/phy/ti,omap-usb2.yaml | 72 +++++++++++++++++++
> > .../devicetree/bindings/phy/ti-phy.txt | 37 ----------
> > 2 files changed, 72 insertions(+), 37 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml b/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
> > new file mode 100644
> > index 000000000000..a05110351814
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/ti,omap-usb2.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: OMAP USB2 PHY
> > +
> > +maintainers:
> > + - Kishon Vijay Abraham I <kishon@ti.com>
> > + - Roger Quadros <rogerq@ti.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - ti,dra7x-usb2
> > + - ti,dra7x-usb2-phy2
> > + - ti,am654-usb2
>
> I missed these two.
> "ti,omap5-usb2"
> "ti,am437x-usb2"
>
> While "ti,am437x-usb2" is being used in the device tree files
> I don't see "ti,omap5-usb2" being used anywhere.
>
> omap5-l4.dtsi uses "ti,omap-usb2"
>
> Should we get rid of "ti,omap5-usb2"?
Sure drop them ;-) we can always add back when we have a user
--
~Vinod
prev parent reply other threads:[~2020-08-31 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:11 [PATCH v4] dt-binding: phy: convert ti,omap-usb2 to YAML Roger Quadros
2020-08-24 7:47 ` Roger Quadros
2020-08-31 11:11 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831111133.GP2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).