From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F15C433E6 for ; Mon, 31 Aug 2020 18:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66C99208DB for ; Mon, 31 Aug 2020 18:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tbpDwtgB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729737AbgHaSTe (ORCPT ); Mon, 31 Aug 2020 14:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729723AbgHaSTV (ORCPT ); Mon, 31 Aug 2020 14:19:21 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EB5BC061573 for ; Mon, 31 Aug 2020 11:19:21 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id h1so1547710qvo.9 for ; Mon, 31 Aug 2020 11:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t1/Tbd4L56MeL2p75ATvjZTyO/Tm7hkvDW3bz/swotc=; b=tbpDwtgB2fMMtc4DXh027u/wFKzMbJ5Cc2upysoNYoY31SkshSdvfrxDYT0KcTGXs8 SdJi7cdl3ZoRuz1ubGq96Q2TCNMgbhleQUqjnDvd8ssXP9zG4sJ2imOZ4MdfaqZU21n9 Nzdy4NYs4tE4HoT/Qh1Z6Q3bT9/C+wOwGwrMoBMa6hmVI3L0EP0/j5jjNTPeD2upOUey GOTXlbG90X/p9ebnC4jR3xIMb1eacEQv8Ablpd1UumiQpwKdi67PuHMMTk8B4eiJ67qt +1nYSFsWkV+Y4G3YZLhcyJHeQrM+1v0U6SPfSwxCbVeysov157C49u18RjgaDTsooHks sSrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t1/Tbd4L56MeL2p75ATvjZTyO/Tm7hkvDW3bz/swotc=; b=owsxZMT9vX90yTj3cXaJ8V17FjCP3JbVmJOsD3sUS2rL1vU+/ADR++Bsp/c5pYKu59 5CvOmhehza/TLxP0630tu0TvfjC7m/K/74UsEqcMPhIpe7GI3d/CK8Fik/EK+XKLugM9 cOAUpiy0rnmRSilW9vkXpt1Jq5E/1GQYmMhomSEczLbqnZTdUF7bimjfSkXtlawiPaOf r6cm1NGKKsy8mcfyRIL4HdyQvKGlUfDYPcqplBxhduLzNQQxScn/gkeGiA80OTYDn2+S hWq1Q1vfZ2rHt8aFvF/8WXmI9hBAv+076+TEsz6DEOe5GN4FvQjEvoa872uMAeyG5p23 eTwQ== X-Gm-Message-State: AOAM530WmLdEVZ70Pp1Oh9wGw3Nz///iePzWrJQfrF692tgn7uywC2pf GziZxxjWo4G6U36qrtDHgWaIhw== X-Google-Smtp-Source: ABdhPJyuyZ+ucI3w1yI15tL5bKSeQjAjW64aQ4RSO5hao4Rhp3pGVjo+MhwR7XDy8TnVcv+62efXEQ== X-Received: by 2002:a05:6214:d46:: with SMTP id 6mr2364472qvr.240.1598897960345; Mon, 31 Aug 2020 11:19:20 -0700 (PDT) Received: from uller (ec2-34-197-84-77.compute-1.amazonaws.com. [34.197.84.77]) by smtp.gmail.com with ESMTPSA id y73sm10600006qkb.23.2020.08.31.11.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 11:19:19 -0700 (PDT) Date: Mon, 31 Aug 2020 18:19:18 +0000 From: Bjorn Andersson To: Maulik Shah Cc: maz@kernel.org, linus.walleij@linaro.org, swboyd@chromium.org, evgreen@chromium.org, mka@chromium.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, agross@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org Subject: Re: [PATCH v5 2/6] pinctrl: qcom: Use return value from irq_set_wake() call Message-ID: <20200831181918.GB468@uller> References: <1598113021-4149-1-git-send-email-mkshah@codeaurora.org> <1598113021-4149-3-git-send-email-mkshah@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598113021-4149-3-git-send-email-mkshah@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 22 Aug 16:16 UTC 2020, Maulik Shah wrote: > msmgpio irqchip was not using return value of irq_set_irq_wake() callback > since previously GIC-v3 irqchip neither had IRQCHIP_SKIP_SET_WAKE flag nor > it implemented .irq_set_wake callback. This lead to irq_set_irq_wake() > return error -ENXIO. > > However from 'commit 4110b5cbb014 ("irqchip/gic-v3: Allow interrupt to be > configured as wake-up sources")' GIC irqchip has IRQCHIP_SKIP_SET_WAKE > flag. > > Use return value from irq_set_irq_wake() and irq_chip_set_wake_parent() > instead of always returning success. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Maulik Shah > Reviewed-by: Douglas Anderson > Reviewed-by: Stephen Boyd Acked-by: Bjorn Andersson > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 1c23f5c..1df2322 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -1077,12 +1077,10 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on) > * when TLMM is powered on. To allow that, enable the GPIO > * summary line to be wakeup capable at GIC. > */ > - if (d->parent_data) > - irq_chip_set_wake_parent(d, on); > - > - irq_set_irq_wake(pctrl->irq, on); > + if (d->parent_data && test_bit(d->hwirq, pctrl->skip_wake_irqs)) > + return irq_chip_set_wake_parent(d, on); > > - return 0; > + return irq_set_irq_wake(pctrl->irq, on); > } > > static int msm_gpio_irq_reqres(struct irq_data *d) > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >