From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226BAC433E6 for ; Mon, 31 Aug 2020 18:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0BC42068E for ; Mon, 31 Aug 2020 18:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="De60GL1O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729472AbgHaSdR (ORCPT ); Mon, 31 Aug 2020 14:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728881AbgHaSdP (ORCPT ); Mon, 31 Aug 2020 14:33:15 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26368C061755 for ; Mon, 31 Aug 2020 11:33:15 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id n18so5515673qtw.0 for ; Mon, 31 Aug 2020 11:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UAcyAoFOFeExwZF9tW7MfLgxAuJk5pMwJvDO9oFiQTk=; b=De60GL1O9L9kN7NgDfGBry5QLlAacsuoC8jdKD5ZoWq2OJIFp5D0H6tBc+b6/AJLik r0Yppf/BHEmVPCza77yxJ0adDWUxcYY8/l1l0M3D81k7JLJZsFFeTeommFS6OVE4ma/E hk57HL7O6g+Ul5OEAyhjQ0BFpcj7CARyqn3T0Fz5J2DC3quhaZw0CAWqXitsMYCp6cLc tJL5CiIRljD+sMvVrVzmatrqk4ePQuLLyw+oifXbrQlIMnCcK78CxmoWEa+hCQe5FHPg zdWGkNflZLT450Zdu1uHzSqBdLIGnv4S2qFpv698zjvW/tlH+ZB0KR0fjqD8lE7UQx1n UX9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UAcyAoFOFeExwZF9tW7MfLgxAuJk5pMwJvDO9oFiQTk=; b=lCfHWvJ5ip7Pe9kw9d/4myq7BK4rcHNoMb1nlgsZQ1vFUoYaylCmr0zBKk5Au6Buj6 ZNA8NEeVb+JYtmMfuVuSoRP5atDvitA25OFTEhKE9mgTNkozT2JDgSeWMxhW3pKvy1yP 2fQwMzCAVktPBQwE6G4/rN2YE7klTLfXmP77p4GG3ex8R9XM0+epCdVGdXS0RO2zsaLs PBTpoxOGZQc+0s2t32yqavcbulc3vT2UIVKuJiwDpK+jZwAMqwgpzqU8I2p83Uip9Spu g2UBPjzTg/iGAPOzlpCZZCR6M6Q5HOLoyEk12O33vnBFg9BfFoVJ+eUmAJYK5bUJpVlx wGKA== X-Gm-Message-State: AOAM531I4GFArIgrrkw6PZY+Aew36HpXJbeaUKYQcr2G0CEnnBkHtayt Yg89b5e3Sb8q26eudGAFoarOgg== X-Google-Smtp-Source: ABdhPJxMYVLW/OqNwsAnPKkGVetBrH5C2vVqfm7r+pHWg/iKcznPIFe/SPY5WC7Z0UckiSB9A0Pbyw== X-Received: by 2002:ac8:22ea:: with SMTP id g39mr2656182qta.146.1598898794310; Mon, 31 Aug 2020 11:33:14 -0700 (PDT) Received: from uller (ec2-34-197-84-77.compute-1.amazonaws.com. [34.197.84.77]) by smtp.gmail.com with ESMTPSA id m17sm11533922qkn.45.2020.08.31.11.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 11:33:13 -0700 (PDT) Date: Mon, 31 Aug 2020 18:33:12 +0000 From: Bjorn Andersson To: Maulik Shah Cc: maz@kernel.org, linus.walleij@linaro.org, swboyd@chromium.org, evgreen@chromium.org, mka@chromium.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, agross@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org Subject: Re: [PATCH v5 1/6] pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags Message-ID: <20200831183312.GC468@uller> References: <1598113021-4149-1-git-send-email-mkshah@codeaurora.org> <1598113021-4149-2-git-send-email-mkshah@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598113021-4149-2-git-send-email-mkshah@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 22 Aug 16:16 UTC 2020, Maulik Shah wrote: > Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs during > suspend and mask before setting irq type. > > Masking before changing type should make sure any spurious interrupt is not > detected during this operation. > This seems like two different problems and both descriptions are thin on details imho. If you're respinning the series I would appreciate if you improved this. Otherwise Acked-by: Bjorn Andersson Regards, Bjorn > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Acked-by: Linus Walleij > Reviewed-by: Douglas Anderson > Signed-off-by: Maulik Shah > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index a2567e7..1c23f5c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -1243,6 +1243,8 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > pctrl->irq_chip.irq_release_resources = msm_gpio_irq_relres; > pctrl->irq_chip.irq_set_affinity = msm_gpio_irq_set_affinity; > pctrl->irq_chip.irq_set_vcpu_affinity = msm_gpio_irq_set_vcpu_affinity; > + pctrl->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND | > + IRQCHIP_SET_TYPE_MASKED; > > np = of_parse_phandle(pctrl->dev->of_node, "wakeup-parent", 0); > if (np) { > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >