From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE76C433E6 for ; Tue, 1 Sep 2020 05:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCB8020767 for ; Tue, 1 Sep 2020 05:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598939501; bh=z5XCUQAfrvapBmSGoVWTsEXnaABO6mMpxg+ww00LI1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UBR2Kl0XWrMFDj0rR2EGuLUt5XehVC3y/5cNp+Pd6YbEkGZrPC2QInKvEf4FsHBgW L3lh9urFcRQxQLBcdSX56sPsGWtXRF1traMTyws7RVcWaxrAYbYRb2uUWThXWOsisY 2Ijb0AFhz3k4+em0C5V/OpFLRXJnparZNJhg/w0s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgIAFvk (ORCPT ); Tue, 1 Sep 2020 01:51:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:40072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbgIAFvj (ORCPT ); Tue, 1 Sep 2020 01:51:39 -0400 Received: from localhost (unknown [122.172.190.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F41B20767; Tue, 1 Sep 2020 05:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598939499; bh=z5XCUQAfrvapBmSGoVWTsEXnaABO6mMpxg+ww00LI1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FbiMqz9Ssh5FnfjQ1l/ceIE+gUOnjtAMrEnwEQEUvR3Z8ZFC8r5cJLA2HoTDmh/xN yDFwCcIWYNHXqddMfxRNaQ0L2FD4MHmxACaiksZHGWC1k6OfDUo4sCDfHaeoQRujqf V3QtPByy6EWETerkV6C4rbQBnJdQfsbB4RCFO1UA= Date: Tue, 1 Sep 2020 11:21:35 +0530 From: Vinod Koul To: "Wan Mohamad, Wan Ahmad Zainie" Cc: "kishon@ti.com" , "robh+dt@kernel.org" , "Shevchenko, Andriy" , "eswara.kota@linux.intel.com" , "vadivel.muruganx.ramuthevar@linux.intel.com" , "Raja Subramanian, Lakshmi Bai" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v7 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings Message-ID: <20200901055135.GY2639@vkoul-mobl> References: <20200821113747.2912-1-wan.ahmad.zainie.wan.mohamad@intel.com> <20200821113747.2912-3-wan.ahmad.zainie.wan.mohamad@intel.com> <20200831091013.GL2639@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-09-20, 04:58, Wan Mohamad, Wan Ahmad Zainie wrote: > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/phy/intel,keembay-emmc- > > phy.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Intel Keem Bay eMMC PHY bindings > > > > This seems same as > > Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml, why > > not add a new compatible in lgm binding, or did I miss a difference? > > AFAIK, LGM make use of syscon node, whilst KMB does not. > And LGM and KMB belongs to different SoC family. So, I prefer them to > be in separate file. > > Having said that, with few changes in wordings in title and description, > I think we can make it generic and can be used across few products. The bindings seems quite similar. We can have two drivers loaded using two compatible but binding description can be made same -- ~Vinod