From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216A4C433E2 for ; Tue, 1 Sep 2020 15:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1215206EB for ; Tue, 1 Sep 2020 15:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729295AbgIAPQQ (ORCPT ); Tue, 1 Sep 2020 11:16:16 -0400 Received: from verein.lst.de ([213.95.11.211]:53788 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729196AbgIAPPU (ORCPT ); Tue, 1 Sep 2020 11:15:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0B52968B05; Tue, 1 Sep 2020 17:15:19 +0200 (CEST) Date: Tue, 1 Sep 2020 17:15:18 +0200 From: Christoph Hellwig To: Josef Bacik Cc: hch@lst.de, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, kernel-team@fb.com Subject: Re: [PATCH 5/6] parport: rework procfs handlers to take advantage of the new buffer Message-ID: <20200901151518.GE30709@lst.de> References: <20200813210411.905010-1-josef@toxicpanda.com> <20200813210411.905010-6-josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200813210411.905010-6-josef@toxicpanda.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 13, 2020 at 05:04:10PM -0400, Josef Bacik wrote: > The buffer coming from higher up the stack has an extra byte to handle > the NULL terminator in the string. Instead of using a temporary buffer > to sprintf into and then copying into the buffer, just scnprintf > directly into the buffer and update lenp as appropriate. > > Signed-off-by: Josef Bacik Looks good, Reviewed-by: Christoph Hellwig