From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FCFC433E2 for ; Tue, 1 Sep 2020 19:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E57C20767 for ; Tue, 1 Sep 2020 19:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731773AbgIATMd (ORCPT ); Tue, 1 Sep 2020 15:12:33 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38663 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728638AbgIATMd (ORCPT ); Tue, 1 Sep 2020 15:12:33 -0400 X-Originating-IP: 90.66.108.79 Received: from localhost (lfbn-lyo-1-1932-79.w90-66.abo.wanadoo.fr [90.66.108.79]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A11C8FF807; Tue, 1 Sep 2020 19:12:27 +0000 (UTC) Date: Tue, 1 Sep 2020 21:12:27 +0200 From: Alexandre Belloni To: Krzysztof Kozlowski Cc: Kyungmin Park , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Nicolas Ferre , Ludovic Desroches , Han Xu , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/6] mtd: rawnand: atmel: Simplify with dev_err_probe() Message-ID: <20200901191227.GK3204668@piout.net> References: <20200901142535.12819-1-krzk@kernel.org> <20200901142535.12819-2-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901142535.12819-2-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2020 16:25:31+0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alexandre Belloni > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index c9818f548d07..71e2b83485d7 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -1976,13 +1976,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > platform_set_drvdata(pdev, nc); > > nc->pmecc = devm_atmel_pmecc_get(dev); > - if (IS_ERR(nc->pmecc)) { > - ret = PTR_ERR(nc->pmecc); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "Could not get PMECC object (err = %d)\n", > - ret); > - return ret; > - } > + if (IS_ERR(nc->pmecc)) > + return dev_err_probe(dev, PTR_ERR(nc->pmecc), > + "Could not get PMECC object\n"); > > if (nc->caps->has_dma && !atmel_nand_avoid_dma) { > dma_cap_mask_t mask; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com