From: Frederic Weisbecker <frederic@kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] nohz: try to avoid IPI when configuring per-CPU posix timer
Date: Wed, 2 Sep 2020 01:38:59 +0200 [thread overview]
Message-ID: <20200901233858.GA9322@lenoir> (raw)
In-Reply-To: <20200825184414.442457749@fuller.cnet>
On Tue, Aug 25, 2020 at 03:41:48PM -0300, Marcelo Tosatti wrote:
> When enabling per-CPU posix timers, an IPI to nohz_full CPUs might be
> performed (to re-read the dependencies and possibly not re-enter
> nohz_full on a given CPU).
>
> A common case is for applications that run on nohz_full= CPUs
> to not use POSIX timers (eg DPDK). This patch skips the IPI
> in case the task allowed mask does not intersect with nohz_full= CPU mask,
> when going through tick_nohz_dep_set_signal.
>
> This reduces interruptions to nohz_full= CPUs.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
[...]
> /*
> + * Set bit on nohz full dependency, kicking all cpus
> + * only if task can run on nohz full CPUs.
> + */
> +static void tick_nohz_dep_set_all_cond(struct task_struct *tsk,
> + atomic_t *dep,
> + enum tick_dep_bits bit)
> +{
> + int prev;
> + unsigned long flags;
> +
> + prev = atomic_fetch_or(BIT(bit), dep);
> + if (prev)
> + return;
> +
> + raw_spin_lock_irqsave(&tsk->pi_lock, flags);
> + if (cpumask_intersects(&tsk->cpus_mask, tick_nohz_full_mask))
> + tick_nohz_full_kick_all();
So that's for one task but what about the other threads in that
process? We are setting the tick dependency on all tasks sharing that
struct signal.
Thanks.
> + raw_spin_unlock_irqrestore(&tsk->pi_lock, flags);
> +}
> +
next prev parent reply other threads:[~2020-09-01 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 18:41 [patch 0/2] posix-timers: avoid nohz_full= IPIs via task cpu masks Marcelo Tosatti
2020-08-25 18:41 ` [patch 1/2] nohz: try to avoid IPI when configuring per-CPU posix timer Marcelo Tosatti
2020-09-01 23:38 ` Frederic Weisbecker [this message]
2020-09-02 19:42 ` Marcelo Tosatti
2020-08-25 18:41 ` [patch 2/2] nohz: try to avoid IPI when setting tick dependency for task Marcelo Tosatti
2020-09-03 15:01 ` Frederic Weisbecker
2020-09-10 18:51 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901233858.GA9322@lenoir \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).