Re: [PATCH v2 09/12] phy: tegra: xusb: t186: support wake and sleepwalk

From: kernel test robot <lkp@intel.com>
To: JC Kuo <jckuo@nvidia.com>,
	gregkh@linuxfoundation.org, thierry.reding@gmail.com,
	robh@kernel.org, jonathanh@nvidia.com, kishon@ti.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	nkristam@nvidia.com
Subject: Re: [PATCH v2 09/12] phy: tegra: xusb: t186: support wake and sleepwalk
Date: Wed, 2 Sep 2020 00:51:56 +0800	[thread overview]
Message-ID: <202009020047.U8oiVL40%lkp@intel.com> (raw)
In-Reply-To: <20200831044043.1561074-10-jckuo@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 2983 bytes --]

Hi JC,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on robh/for-next usb/usb-testing char-misc/char-misc-testing staging/staging-testing driver-core/driver-core-testing v5.9-rc3 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/JC-Kuo/Tegra-XHCI-controller-ELPG-support/20200831-124234
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm64-randconfig-r014-20200901 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c10e63677f5d20f18010f8f68c631ddc97546f7d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/phy/tegra/xusb-tegra186.c:1561:5: warning: no previous prototype for function 'tegra186_xusb_padctl_remote_wake_detected' [-Wmissing-prototypes]
   int tegra186_xusb_padctl_remote_wake_detected(struct phy *phy)
       ^
   drivers/phy/tegra/xusb-tegra186.c:1561:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int tegra186_xusb_padctl_remote_wake_detected(struct phy *phy)
   ^
   static 
   1 warning generated.

# https://github.com/0day-ci/linux/commit/405a5b91f6af8144ded6842a07a86e53f967fde2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review JC-Kuo/Tegra-XHCI-controller-ELPG-support/20200831-124234
git checkout 405a5b91f6af8144ded6842a07a86e53f967fde2
vim +/tegra186_xusb_padctl_remote_wake_detected +1561 drivers/phy/tegra/xusb-tegra186.c

  1560	
> 1561	int tegra186_xusb_padctl_remote_wake_detected(struct phy *phy)
  1562	{
  1563		struct tegra_xusb_lane *lane;
  1564		struct tegra_xusb_padctl *padctl;
  1565		unsigned int index;
  1566	
  1567		if (!phy)
  1568			return 0;
  1569	
  1570		lane = phy_get_drvdata(phy);
  1571		padctl = lane->pad->padctl;
  1572		index = lane->index;
  1573	
  1574		if (is_utmi_phy(phy))
  1575			return tegra186_utmi_phy_remote_wake_detected(padctl, index);
  1576		else if (is_usb3_phy(phy))
  1577			return tegra186_usb3_phy_remote_wake_detected(padctl, index);
  1578		else
  1579			return -EINVAL;
  1580	}
  1581	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37356 bytes --]