From: Leon Romanovsky <leon@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
linux-kernel@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH rdma-next 2/4] gcov: Use proper duplication routine for const pointer
Date: Wed, 2 Sep 2020 11:55:11 +0300 [thread overview]
Message-ID: <20200902085513.748149-3-leon@kernel.org> (raw)
In-Reply-To: <20200902085513.748149-1-leon@kernel.org>
From: Leon Romanovsky <leonro@nvidia.com>
The filename is a const pointer, so use the proper string duplication
routine that takes into account const identifier.
Cc: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
kernel/gcov/gcc_4_7.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index 6d706c5eed5c..318211deb903 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -283,7 +283,7 @@ struct gcov_info *gcov_info_dup(struct gcov_info *info)
dup->merge[fi_idx] = info->merge[fi_idx];
dup->n_functions = info->n_functions;
- dup->filename = kstrdup(info->filename, GFP_KERNEL);
+ dup->filename = kstrdup_const(info->filename, GFP_KERNEL);
if (!dup->filename)
goto err_free;
@@ -359,7 +359,7 @@ void gcov_info_free(struct gcov_info *info)
free_info:
kfree(info->functions);
- kfree(info->filename);
+ kfree_const(info->filename);
kfree(info);
}
--
2.26.2
next prev parent reply other threads:[~2020-09-02 8:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:55 [PATCH -rc 0/4] Protect from GCC garbage input in GCOV Leon Romanovsky
2020-09-02 8:55 ` [PATCH rdma-next 1/4] gcov: Open-code kmemdup() to work correctly with kernel and user space pointers Leon Romanovsky
2020-09-02 17:38 ` Linus Torvalds
2020-09-02 17:46 ` Leon Romanovsky
2020-09-02 18:27 ` Linus Torvalds
2020-09-02 18:44 ` Leon Romanovsky
2020-09-02 19:04 ` Linus Torvalds
2020-09-02 8:55 ` Leon Romanovsky [this message]
2020-09-03 8:56 ` [PATCH rdma-next 2/4] gcov: Use proper duplication routine for const pointer Rasmus Villemoes
2020-09-03 10:38 ` Leon Romanovsky
2020-09-02 8:55 ` [PATCH rdma-next 3/4] gcov: Protect from uninitialized number of functions provided by GCC 10.2 Leon Romanovsky
2020-09-02 17:41 ` Linus Torvalds
2020-09-02 8:55 ` [PATCH rdma-next 4/4] gcov: Don't print out-of-memory print for all failed files Leon Romanovsky
2020-09-02 17:42 ` [PATCH -rc 0/4] Protect from GCC garbage input in GCOV Linus Torvalds
2020-09-02 17:52 ` Leon Romanovsky
2020-09-02 18:24 ` Linus Torvalds
2020-09-02 18:28 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902085513.748149-3-leon@kernel.org \
--to=leon@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).