From: Jessica Yu <jeyu@kernel.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-kernel@vger.kernel.org, jeyu@suse.de,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] module: Add more error message for failed kernel module loading
Date: Wed, 2 Sep 2020 11:40:19 +0200 [thread overview]
Message-ID: <20200902094019.GA7287@linux-8ccs> (raw)
In-Reply-To: <20200902064619.67343-1-wqu@suse.com>
+++ Qu Wenruo [02/09/20 14:46 +0800]:
>When kernel module loading failed, user space only get one of the
>following error messages:
>
>- ENOEXEC
> This is the most confusing one. From corrupted ELF header to bad
> WRITE|EXEC flags check introduced by in module_enforce_rwx_sections()
> all returns this error number.
>
>- EPERM
> This is for blacklisted modules. But mod doesn't do extra explain
> on this error either.
>
>- ENOMEM
> The only error which needs no explain.
>
>This means, if a user got "Exec format error" from modprobe, it provides
>no meaningful way for the user to debug, and will take extra time
>communicating to get extra info.
>
>So this patch will add extra error messages for -ENOEXEC and -EPERM
>errors, allowing user to do better debugging and reporting.
>
>Signed-off-by: Qu Wenruo <wqu@suse.com>
>Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Applied, thanks.
Jessica
next prev parent reply other threads:[~2020-09-02 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 6:46 [PATCH] module: Add more error message for failed kernel module loading Qu Wenruo
2020-09-02 9:40 ` Jessica Yu [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-31 8:37 Qu Wenruo
2020-09-01 14:05 ` Jessica Yu
2020-08-29 11:14 Qu Wenruo
2020-09-01 18:50 ` Lucas De Marchi
2020-09-01 19:56 ` Prarit Bhargava
2020-09-01 20:17 ` Lucas De Marchi
2020-09-02 0:06 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902094019.GA7287@linux-8ccs \
--to=jeyu@kernel.org \
--cc=jeyu@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).