From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Add VM-Enter failed tracepoints for super early checks
Date: Wed, 2 Sep 2020 15:14:31 -0700 [thread overview]
Message-ID: <20200902221430.GJ11695@sjchrist-ice> (raw)
In-Reply-To: <87v9gxx5z8.fsf@vitty.brq.redhat.com>
On Tue, Sep 01, 2020 at 10:21:15AM +0200, Vitaly Kuznetsov wrote:
> Sean Christopherson <sean.j.christopherson@intel.com> writes:
>
> > Add tracepoints for the early consistency checks in nested_vmx_run().
> > The "VMLAUNCH vs. VMRESUME" check in particular is useful to trace, as
> > there is no architectural way to check VMCS.LAUNCH_STATE, and subtle
> > bugs such as VMCLEAR on the wrong HPA can lead to confusing errors in
> > the L1 VMM.
> >
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> > ---
> > arch/x86/kvm/vmx/nested.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> > index 23b58c28a1c92..fb37f0972e78a 100644
> > --- a/arch/x86/kvm/vmx/nested.c
> > +++ b/arch/x86/kvm/vmx/nested.c
> > @@ -3468,11 +3468,11 @@ static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch)
> > if (evmptrld_status == EVMPTRLD_ERROR) {
>
> Would it make sense to add 'CC' here too for, em, consistency? :-) #UD
> is probably easy to spot anyway..
I'd prefer not to, purely because it's a #UD and not a VM-Fail.
next prev parent reply other threads:[~2020-09-02 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 18:06 [PATCH] KVM: nVMX: Add VM-Enter failed tracepoints for super early checks Sean Christopherson
[not found] ` <87v9gxx5z8.fsf@vitty.brq.redhat.com>
2020-09-02 22:14 ` Sean Christopherson [this message]
2020-09-23 16:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902221430.GJ11695@sjchrist-ice \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).