From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C81C433E7 for ; Wed, 2 Sep 2020 23:00:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB5122080C for ; Wed, 2 Sep 2020 23:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="iwrw74Q1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbgIBXAO (ORCPT ); Wed, 2 Sep 2020 19:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbgIBW7h (ORCPT ); Wed, 2 Sep 2020 18:59:37 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2528C061244 for ; Wed, 2 Sep 2020 15:59:34 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id d26so819585yba.20 for ; Wed, 02 Sep 2020 15:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=hff3G+QLGxV/ViGmhPCtlvmXNd4WANBDwQ3lAuZV0Mw=; b=iwrw74Q1XQR8aetxPyj7X2JT/yrRvwxttKGJSalOf27LJjRNgw5LdTGmBi4zW87gzJ jWv/YEvq5Zbo3RpMnk5y1ZdPzkiOZbs0cuRfKqDKO8OW5mq+mZ+C2IIOaUyvJuJA5Ut+ fwlpdlv6vAjbVeRBP48LkhTULyIMThwfS9on6nc6WyXEdbOeGL+I4M/jhT3zZTfZBxaa kr3EWqG+AfGLNAUy+Hg2rN/DMRWME1kQh61uaJzCU3+2chJMjZFw4rzpb0YIlTOoXn71 sA9Cw+rDwZzpxHBgrbuHNCcWyIKv13brHg6X0t31wzmsHpHoImnLzA3eCHBWn09yRjrR T3cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hff3G+QLGxV/ViGmhPCtlvmXNd4WANBDwQ3lAuZV0Mw=; b=qOdig8yTCJTWj8VEWdgSXLp90djEbsCS8PLpiFZOvJNl+25umTJn6Q752PWTflo1uE 2qu0abzdp7cGDszbOXCWDAtBZSk1OY9NRouVYXgmH8CH4YV65+RZNwiDFh1ypd3Nivpy 6wgiVdxvdKLQnTyz//4boKmpAi5x72n1QzDSEIxDAVI55yk5M5tXVASIdggZjVQKiZcx +sFiLiF+CV4oopHzSxq7kRdeuoyoTHORioBYEJB7+PjwzSmam5krdvy6YvhsGe5FnaRu pVwqZiYDKGi5muwl1a9t67V3UjHgTV5j58FtdyVNXMd2gzEyHGRpTVPblqZn7dQAD5UQ MJ3A== X-Gm-Message-State: AOAM533HBVnQWv1sd5cu8uFdxG3CrQokcXI7tbXOCmYzUFOsTLhPUIBI DJ/ANU+geN8p+WUqfFH6nBrApZWAMMbNSGkTpmA= X-Google-Smtp-Source: ABdhPJz8HsXqhbzv3WyaE2hRsJShfNIeKayY5AyYc2Ztb61p7tA6BncgoQhhEmGaA+pb9MRBq7EHu8ZTXm6gCOA9puw= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a25:8b09:: with SMTP id i9mr1782ybl.149.1599087574125; Wed, 02 Sep 2020 15:59:34 -0700 (PDT) Date: Wed, 2 Sep 2020 15:59:11 -0700 In-Reply-To: <20200902225911.209899-1-ndesaulniers@google.com> Message-Id: <20200902225911.209899-8-ndesaulniers@google.com> Mime-Version: 1.0 References: <20200902225911.209899-1-ndesaulniers@google.com> X-Mailer: git-send-email 2.28.0.402.g5ffc5be6b7-goog Subject: [PATCH v3 7/7] compiler-gcc: improve version error From: Nick Desaulniers To: Andrew Morton Cc: Kees Cook , Miguel Ojeda , Nathan Chancellor , Sedat Dilek , Marco Elver , Andrey Konovalov , Masahiro Yamada , clang-built-linux@googlegroups.com, Daniel Borkmann , Alexei Starovoitov , Will Deacon , Vincenzo Frascino , linux-kernel@vger.kernel.org, Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Kees suggests, doing so provides developers with two useful pieces of information: - The kernel build was attempting to use GCC. (Maybe they accidentally poked the wrong configs in a CI.) - They need 4.9 or better. ("Upgrade to what version?" doesn't need to be dug out of documentation, headers, etc.) Reviewed-by: Kees Cook Reviewed-by: Miguel Ojeda Reviewed-by: Nathan Chancellor Reviewed-by: Sedat Dilek Suggested-by: Kees Cook Tested-by: Sedat Dilek Signed-off-by: Nick Desaulniers --- include/linux/compiler-gcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 7a3769040d7d..d1e3c6896b71 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -12,7 +12,7 @@ /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ #if GCC_VERSION < 40900 -# error Sorry, your compiler is too old - please upgrade it. +# error Sorry, your version of GCC is too old - please use 4.9 or newer. #endif /* Optimization barrier */ -- 2.28.0.402.g5ffc5be6b7-goog