linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: James Clark <james.clark@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Namhyung Kim <namhyung@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	Ian Rogers <irogers@google.com>,
	Kemeng Shi <shikemeng@huawei.com>, Wei Li <liwei391@huawei.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Al Grant <Al.Grant@arm.com>,
	linux-kernel@vger.kernel.org,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Mike Leach <mike.leach@linaro.org>, nd <nd@arm.com>
Subject: Re: [PATCH RESEND v1 05/11] perf mem: Support AUX trace
Date: Thu, 3 Sep 2020 17:07:24 +0800	[thread overview]
Message-ID: <20200903090724.GB1583@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <7b0e61d3-3f28-0e98-9c82-b9a9573bf571@arm.com>

Hi James,

On Tue, Sep 01, 2020 at 04:52:54PM +0100, James Clark wrote:
> Hi Leo,
> 
> >  
> > +static int process_attr(struct perf_tool *tool __maybe_unused,
> > +			union perf_event *event,
> > +			struct evlist **pevlist)
> > +{
> > +	int err;
> > +
> > +	err = perf_event__process_attr(tool, event, pevlist);
> > +	if (err)
> > +		return err;
> > +
> > +	return 0;
> > +}
> > +
> >  int cmd_mem(int argc, const char **argv)
> >  {
> >  	struct stat st;
> > @@ -405,8 +430,12 @@ int cmd_mem(int argc, const char **argv)
> >  			.comm		= perf_event__process_comm,
> >  			.lost		= perf_event__process_lost,
> >  			.fork		= perf_event__process_fork,
> > +			.attr		= process_attr,
> >  			.build_id	= perf_event__process_build_id,
> 
> I don't understand the __maybe_unused here. And also isn't this equivalent
> to this without the new function:
> 
>   @@ -405,8 +430,12 @@ int cmd_mem(int argc, const char **argv)
>    			.comm		= perf_event__process_comm,
>    			.lost		= perf_event__process_lost,
>    			.fork		= perf_event__process_fork,
>   +			.attr		= perf_event__process_attr,
>    			.build_id	= perf_event__process_build_id,

Thanks for pointing out this, will fix this with your suggestion.

Thanks,
Leo

  reply	other threads:[~2020-09-03  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06  3:07 [PATCH RESEND v1 00/11] perf mem: Support AUX trace and Arm SPE Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 01/11] perf mem: Search event name with more flexible path Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 02/11] perf mem: Introduce weak function perf_mem_events__ptr() Leo Yan
2020-08-28 15:40   ` James Clark
2020-08-31  2:52     ` Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 03/11] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 04/11] perf mem: Only initialize memory event for recording Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 05/11] perf mem: Support AUX trace Leo Yan
2020-09-01 15:52   ` James Clark
2020-09-03  9:07     ` Leo Yan [this message]
2020-08-06  3:07 ` [PATCH RESEND v1 06/11] perf mem: Support Arm SPE events Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 07/11] perf arm-spe: Enable attribution PERF_SAMPLE_DATA_SRC Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 08/11] perf arm-spe: Save memory addresses in packet Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 09/11] perf arm-spe: Store operation types " Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 10/11] perf arm-spe: Fill address info for memory samples Leo Yan
2020-08-06  3:07 ` [PATCH RESEND v1 11/11] perf arm-spe: Set sample's data source field Leo Yan
2020-09-01 16:36 ` [PATCH RESEND v1 00/11] perf mem: Support AUX trace and Arm SPE James Clark
2020-09-03  9:13   ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903090724.GB1583@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=Al.Grant@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=nd@arm.com \
    --cc=peterz@infradead.org \
    --cc=shikemeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).