From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83D2C433E2 for ; Thu, 3 Sep 2020 21:56:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E114205CB for ; Thu, 3 Sep 2020 21:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Seros2DT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728666AbgICV4R (ORCPT ); Thu, 3 Sep 2020 17:56:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728622AbgICV4L (ORCPT ); Thu, 3 Sep 2020 17:56:11 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E23C061245 for ; Thu, 3 Sep 2020 14:56:11 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id b124so3397508pfg.13 for ; Thu, 03 Sep 2020 14:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+qkcq0KaVk7HSQBAkByrnKJ1sZBfvqUX0j4GLf7P4Ho=; b=Seros2DTlS5cvJrc6eXGVeiAHZSqw0rR2qykzMdKQEtfa4XdwNdSID5ZkvediVM9AJ O7omW08AaLWNFuSJ2HD93Wkv2v202rCTP6thwQMutIbbVLf7kd+B9GMFYWvsh9yIgl4o wj2jIiZYQWQu0rnmAlwzd4ky0DUpgiwfDRBxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+qkcq0KaVk7HSQBAkByrnKJ1sZBfvqUX0j4GLf7P4Ho=; b=nGQzv+WTiipAjuMVJsL7SM+1V2gXnQFpcieXJ0amlA00nkcXcc5MdQxVD2/DoOd9mu NpAjrfgGHQ6y2b6te2SVolQNvOwv2/eTDwUBF8feQj77lwgRgcTZ9C0pyhSQvl0vaH8Z r66Cr4V2v7OMn+mKnCbq9imEXCdRnTgFJ8ecszbuGaKi6QCntHKvJRvRv+v4lF7vnYdi CTloHzNcMqObUSoRA2/TtXT/ksX3ysyYcPVywoh9+0TUVmcbUMToGn4EcbT232Mp51yG wJErktUqt7TxNJED8Rrni7QkW45wN36tt52vqxy83YSro+wlFCbLbGFKcY5ewhcwRo1G CCeA== X-Gm-Message-State: AOAM532FLZdMHp+pZTzGy7h9/tn9Xon7qWRKyJsWxg3JmAjRpIjAmKA9 sFGTcr31M5IhkyVuHaZUC+QchA== X-Google-Smtp-Source: ABdhPJyOa4sKb29bYinReMEHv5PsZTZST1EHUNe/55RA0OQy4wRKFNRcU2420Azk0bfn+Y9cX+tWeg== X-Received: by 2002:a62:fccf:: with SMTP id e198mr5659849pfh.183.1599170170933; Thu, 03 Sep 2020 14:56:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r3sm4349799pfh.88.2020.09.03.14.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:56:10 -0700 (PDT) Date: Thu, 3 Sep 2020 14:56:09 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 07/28] kbuild: add support for objtool mcount Message-ID: <202009031455.A305DD4F97@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-8-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-8-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:32PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > This change adds build support for using objtool to generate > __mcount_loc sections. > > Signed-off-by: Sami Tolvanen Looks right to me. (There is probably an argument to be made to do all of the tooling detection in the Kconfig, but that's a larger issues and orthogonal to this fix, IMO.) Reviewed-by: Kees Cook -- Kees Cook