From: Daniel Thompson <daniel.thompson@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Kyle Huey <me@kylehuey.com>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Robert O'Callahan <rocallahan@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joel@joelfernandes.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>, Brian Gerst <brgerst@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH 00/13] x86/debug: Untangle handle_debug()
Date: Thu, 3 Sep 2020 16:21:20 +0100 [thread overview]
Message-ID: <20200903152120.zroztjtwqtx37asg@holly.lan> (raw)
In-Reply-To: <20200902132549.496605622@infradead.org>
On Wed, Sep 02, 2020 at 03:25:49PM +0200, Peter Zijlstra wrote:
> Hi,
>
> The first two patches probably ought to go in x86/urgent, the rest (!RFC) can
> go into x86/core and wait a bit.
>
> handle_debug() is a mess, and now that we have separate user and kernel paths,
> try and clean it up a bit.
>
> There's two RFC patches at the end that impact the ptrace_{get,set}_debugreg(6)
> ABI, I've no idea what, if anything, is expected of that or if anybody actually
> cares about that. If I read the code correctly nothing actually consumes the
> value from ptrace_set_debugreg(6).
I applied this both with and without the RFC patches and pointed the
(still work-in-progress) kgdb test suite at it. I won't pretend the
suite is comprehensive but nevertheless FWIW:
Tested-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
>
> Kyle, you seem to be pushing all this to the edge with RR, any clues?
>
> Since v2:
>
> - fixed (user) INT1 / icebp detection
> - some further cleanups
> - two additional RFC patches
>
prev parent reply other threads:[~2020-09-03 15:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 13:25 [PATCH 00/13] x86/debug: Untangle handle_debug() Peter Zijlstra
2020-09-02 13:25 ` [PATCH 01/13] x86/entry: Fix AC assertion Peter Zijlstra
2020-09-02 15:58 ` Brian Gerst
2020-09-02 16:24 ` Jürgen Groß
2020-09-02 16:31 ` peterz
2020-09-02 17:02 ` Brian Gerst
2020-09-02 16:26 ` Andrew Cooper
2020-09-04 13:16 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 02/13] x86/debug: Allow a single level of #DB recursion Peter Zijlstra
2020-09-02 23:59 ` Sasha Levin
2020-09-03 16:12 ` Josh Poimboeuf
2020-09-02 13:25 ` [PATCH 03/13] x86/debug: Sync BTF earlier Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 04/13] x86/debug: Move kprobe_debug_handler() into exc_debug_kernel() Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 05/13] x86/debug: Remove handle_debug(.user) argument Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 06/13] x86/debug: Simplify #DB signal code Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 07/13] x86/debug: Move historical SYSENTER junk into exc_debug_kernel() Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 08/13] x86/debug: Move cond_local_irq_enable() block into exc_debug_user() Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 09/13] x86/debug: Remove the historical junk Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:25 ` [PATCH 10/13] x86/debug: Remove aout_dump_debugregs() Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:26 ` [PATCH 11/13] x86/debug: Simplify hw_breakpoint_handler() Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:26 ` [RFC][PATCH 12/13] x86/debug: Support negative polarity DR6 bits Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-02 13:26 ` [RFC][PATCH 13/13] x86/debug: Change thread.debugreg6 to thread.virtual_dr6 Peter Zijlstra
2020-09-04 13:16 ` [tip: x86/entry] " tip-bot2 for Peter Zijlstra
2020-09-03 15:21 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903152120.zroztjtwqtx37asg@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=alexandre.chartre@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brgerst@gmail.com \
--cc=frederic@kernel.org \
--cc=jgross@suse.com \
--cc=joel@joelfernandes.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rocallahan@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sean.j.christopherson@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).