From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D284DC433E2 for ; Thu, 3 Sep 2020 22:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C37A20716 for ; Thu, 3 Sep 2020 22:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XY2V+aPz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbgICWmU (ORCPT ); Thu, 3 Sep 2020 18:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729348AbgICWmQ (ORCPT ); Thu, 3 Sep 2020 18:42:16 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F50C061244 for ; Thu, 3 Sep 2020 15:42:16 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id f18so3485780pfa.10 for ; Thu, 03 Sep 2020 15:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TlwuOH2EQG6MCnppWuU43l955MakvluKpUTVDERTNO8=; b=XY2V+aPzW1+LDnPQgs8LCKdfsW+ukc0CH4hsERu2c197BquhpT6ytbY651mqbWroP5 NoijPo4tmmhjTbE82fXMmxBiTTfrN9b+BObSgnEn5HC00srbReXMVw7CaVxDZQjvWDNb sLqtBJzVmvCGKIRCPcZC9IKz2mLH5Kg/+0yME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TlwuOH2EQG6MCnppWuU43l955MakvluKpUTVDERTNO8=; b=fOuDfKqLsD5k+bGkGym8EsFI98uqDKW+T0OJFrIJxDhIjlmY0nO2+RpC3X3CLRHEA/ rKS3uPzrYfztj4FQO/k6Od1UIzLhalDEuWZKf3PaQNm0CNVxHgg3tKK4FovRP/A2StPX H4pLN2aaZ+k/PiCUEMUFhJFXa7StoilWBbplH9CEX5De/0fVxA+oB+lCTpB8qa50bkfY rPYHHiih9khlggHALk8kIUl1zy4Sn0iVjBa+4iz5l3Du3EMtWoCIpRAxCGjMeHaXOEn3 R6duQPo0Y1+dmX8mhy8n4He6Ix7dTMLitknOPRkoi/S0N0rodVS0a+sw8prE39rxkI63 XwDQ== X-Gm-Message-State: AOAM533rFExTrR68zYbXrNeTRRPTw3F7XwYCAzOCynVuJbezfW/eWloE QbGwT2KtxBsqMaAnkbozLEZxyQ== X-Google-Smtp-Source: ABdhPJyqBzmMfYaY/Mz5zx6mhtV8btCsnKX7oA2efoS7o6nY6a3yOyI6Ra3/iG5Srj/uMw3Z86qeLw== X-Received: by 2002:a63:384b:: with SMTP id h11mr4827548pgn.113.1599172936031; Thu, 03 Sep 2020 15:42:16 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a6sm3760136pgt.70.2020.09.03.15.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:42:14 -0700 (PDT) Date: Thu, 3 Sep 2020 15:42:13 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 17/28] PCI: Fix PREL32 relocations for LTO Message-ID: <202009031542.F6DA50F6@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-18-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-18-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:42PM -0700, Sami Tolvanen wrote: > With Clang's Link Time Optimization (LTO), the compiler can rename > static functions to avoid global naming collisions. As PCI fixup > functions are typically static, renaming can break references > to them in inline assembly. This change adds a global stub to > DECLARE_PCI_FIXUP_SECTION to fix the issue when PREL32 relocations > are used. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook