From: Alex Dewar <alex.dewar90@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alex Dewar <alex.dewar90@gmail.com>,
devel@driverdev.osuosl.org, Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Fix error path in lm3554_probe()
Date: Thu, 3 Sep 2020 19:21:30 +0100 [thread overview]
Message-ID: <20200903182130.ugsbzjyq3yc56mdv@medion> (raw)
In-Reply-To: <20200903173843.GF8299@kadam>
> You're right. I wonder if there is really any need for the
> lm3554_gpio_uninit() function at all? It's basically the same as
> lm3554_gpio_init() except for the order of function calls. Probably
> we could just rename lm3554_gpio_init() to something like
> lm3554_gpio_set_default() and use it in both the probe() and remove
> functions()...
I think you probably also don't want to return error values from
lm3554_gpio_uninit() as it is only called on module removal, so it'd
probably make more sense to just print a warning and carry on. I'll do
this as a separate patch and send it to the list, though.
v2 to follow...
>
> But I don't know the code and can't test it so let's leave that for
> another day.
>
> We still do need to clean up if atomisp_register_i2c_module() fails
> though, and the timer as well so could you resend a v2?
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2020-09-03 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 18:41 [PATCH] staging: media: atomisp: Fix error path in lm3554_probe() Alex Dewar
2020-09-03 12:11 ` Dan Carpenter
2020-09-03 15:48 ` Alex Dewar
2020-09-03 17:38 ` Dan Carpenter
2020-09-03 18:21 ` Alex Dewar [this message]
2020-09-03 18:24 ` [PATCH v2] " Alex Dewar
2020-09-04 6:35 ` Dan Carpenter
2020-09-19 19:50 ` Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903182130.ugsbzjyq3yc56mdv@medion \
--to=alex.dewar90@gmail.com \
--cc=alan@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).