From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, mengdong.lin@intel.com,
sanyog.r.kale@intel.com, rander.wang@linux.intel.com,
bard.liao@intel.com
Subject: Re: [PATCH 0/7] ASoC: soundwire: Move sdw stream operations to
Date: Fri, 4 Sep 2020 10:40:36 +0530 [thread overview]
Message-ID: <20200904051036.GU2639@vkoul-mobl> (raw)
In-Reply-To: <033ea005-e948-c2c6-9bd4-e074d3effde0@linux.intel.com>
On 03-09-20, 09:05, Pierre-Louis Bossart wrote:
>
>
> On 9/3/20 5:42 AM, Vinod Koul wrote:
> > On 01-09-20, 23:02, Bard Liao wrote:
> > > sdw stream operation APIs can be called once per stream. dailink
> > > callbacks are good places to call these APIs.
> >
> > Again, please mention here if this is to be merged thru sdw tree or ASoC
> > tree
>
> Good point, I thought it wouldn't matter but it does. I just gave it a try
> and there seems to be a conflict on Mark's tree w/ drivers/soundwire/intel.c
> (likely due to missing patches already added to Vinod's tree).
>
> So this should go to Vinod's tree with Mark's Acked-by tag on the ASoC
> changes.
>
> Alternatively we can also split this in two, with ASoC-only and
> SoundWire-only patches in separate series if it's easier for maintainers. We
> would lose the rationale for the changes but that's not essential.
If there are no dependencies on each other, that is best preferred
option. One should mention in cover-letter about the linked series
though.
>
> > > Pierre-Louis Bossart (7):
> > > ASoC: soc-dai: clarify return value for get_sdw_stream()
> > > soundwire: stream: fix NULL/IS_ERR confusion
> > > soundwire: intel: fix NULL/ERR_PTR confusion
> > > ASOC: Intel: sof_sdw: add dailink .trigger callback
> > > ASOC: Intel: sof_sdw: add dailink .prepare and .hw_free callback
> >
> > These should be ASoC
>
> Right. if you are fine with the content and this goes in your tree, can this
> be modified while applying? Or do want a v2?
>
> > > soundwire: intel: remove .trigger operation
> > > soundwire: intel: remove stream handling from .prepare and .hw_free
> > >
> > > drivers/soundwire/intel.c | 60 ++++-------------------
> > > drivers/soundwire/stream.c | 2 +-
> > > include/sound/soc-dai.h | 3 +-
> > > sound/soc/intel/boards/sof_sdw.c | 81 ++++++++++++++++++++++++++++++++
> > > 4 files changed, 92 insertions(+), 54 deletions(-)
> > >
> > > --
> > > 2.17.1
> >
--
~Vinod
next prev parent reply other threads:[~2020-09-04 5:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 15:02 [PATCH 0/7] ASoC: soundwire: Move sdw stream operations to Bard Liao
2020-09-01 15:02 ` [PATCH 1/7] ASoC: soc-dai: clarify return value for get_sdw_stream() Bard Liao
2020-09-01 15:02 ` [PATCH 2/7] soundwire: stream: fix NULL/IS_ERR confusion Bard Liao
2020-09-01 15:02 ` [PATCH 3/7] soundwire: intel: fix NULL/ERR_PTR confusion Bard Liao
2020-09-01 15:02 ` [PATCH 4/7] ASOC: Intel: sof_sdw: add dailink .trigger callback Bard Liao
2020-09-01 15:02 ` [PATCH 5/7] ASOC: Intel: sof_sdw: add dailink .prepare and .hw_free callback Bard Liao
2020-09-01 15:02 ` [PATCH 6/7] soundwire: intel: remove .trigger operation Bard Liao
2020-09-01 15:02 ` [PATCH 7/7] soundwire: intel: remove stream handling from .prepare and .hw_free Bard Liao
2020-09-03 10:42 ` [PATCH 0/7] ASoC: soundwire: Move sdw stream operations to Vinod Koul
2020-09-03 14:05 ` Pierre-Louis Bossart
2020-09-04 5:10 ` Vinod Koul [this message]
2020-09-04 8:47 ` Liao, Bard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904051036.GU2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).