From: Andrew Morton <akpm@linux-foundation.org>
To: mateusznosek0@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc.c: Clean code by removing unnecessary initialization
Date: Fri, 4 Sep 2020 11:12:47 -0700 [thread overview]
Message-ID: <20200904111247.371e5bfca967239781e5bf27@linux-foundation.org> (raw)
In-Reply-To: <20200904132422.17387-1-mateusznosek0@gmail.com>
On Fri, 4 Sep 2020 15:24:22 +0200 mateusznosek0@gmail.com wrote:
> From: Mateusz Nosek <mateusznosek0@gmail.com>
>
> Previously variable 'tmp' was initialized, but was not read later
> before reassigning. So the initialization can be removed.
>
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5637,7 +5637,7 @@ static int find_next_best_node(int node, nodemask_t *used_node_mask)
> int n, val;
> int min_val = INT_MAX;
> int best_node = NUMA_NO_NODE;
> - const struct cpumask *tmp = cpumask_of_node(0);
> + const struct cpumask *tmp;
>
> /* Use the local node if we haven't already */
> if (!node_isset(node, *used_node_mask)) {
OK. But we may as well kill tmp altogether?
--- a/mm/page_alloc.c~mm-page_allocc-clean-code-by-removing-unnecessary-initialization-fix
+++ a/mm/page_alloc.c
@@ -5637,7 +5637,6 @@ static int find_next_best_node(int node,
int n, val;
int min_val = INT_MAX;
int best_node = NUMA_NO_NODE;
- const struct cpumask *tmp;
/* Use the local node if we haven't already */
if (!node_isset(node, *used_node_mask)) {
@@ -5658,8 +5657,7 @@ static int find_next_best_node(int node,
val += (n < node);
/* Give preference to headless and unused nodes */
- tmp = cpumask_of_node(n);
- if (!cpumask_empty(tmp))
+ if (!cpumask_empty(cpumask_of_node(n)))
val += PENALTY_FOR_NODE_WITH_CPUS;
/* Slight preference for less loaded node */
_
prev parent reply other threads:[~2020-09-04 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 13:24 [PATCH] mm/page_alloc.c: Clean code by removing unnecessary initialization mateusznosek0
2020-09-04 18:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904111247.371e5bfca967239781e5bf27@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mateusznosek0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).