From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6D4C43461 for ; Fri, 4 Sep 2020 18:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B118A204EC for ; Fri, 4 Sep 2020 18:20:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Il3Jp+Gb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbgIDSUv (ORCPT ); Fri, 4 Sep 2020 14:20:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbgIDSUr (ORCPT ); Fri, 4 Sep 2020 14:20:47 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2195C061246 for ; Fri, 4 Sep 2020 11:20:45 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id t7so433543pjd.3 for ; Fri, 04 Sep 2020 11:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HGsb6HyUfkAH720RyRI2xnBGVpFj14UXqV80lfeeAHQ=; b=Il3Jp+GbZKeQBVyig5AB6ptKPeBzRng/54pElXbWFgDDwVZtfonwW/fIvn12LwA16M q+/RGW9N8udNPgZyH15iLM+vRSiGyHrin+pGX1aElmkbmidG8ekkDrYXabwm5ci/epUm czoHI1JGeVOuHvY1/0vF8Z8gvengMt1dzX9XM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HGsb6HyUfkAH720RyRI2xnBGVpFj14UXqV80lfeeAHQ=; b=txeIDoY1nJNRMfHIHd6zWAyuRKT8j+j39k9LfV4GPyGgLUBD4XS67b3CafabJS9DKi o1NwZRKHhvFtvvbgi58/N95W8p8lwOHYHtwoHdW2qkGHZL0hVSglrnU+i9dsM4Kn4hjh Q+Iqd9TML+SOU4ggTS6dfn6gFwb6isZwcLFBclaPhGTgiR0bgJ9YsDnLWr+HudpwxngX 5UCBtBEuSuIPXN/Rdg9ZWCH2L/E5XdFyDUIKnFr2Q9t6DOnpbKe3NNn7w6Y6abHgpPT3 gTSulLIhdrFYrh2fLw1pADvvxQmNssLIO58uTKEOcl+SzRyX5VB0+HvdppNkE+5A97Gn vqlw== X-Gm-Message-State: AOAM531uuTyTU5zQ4A9zVV3kkm3zt3QAUnoj+mHbdUB6YgOD0HtL4ddQ Y/t+1cw4ZZeZROH13QK5QGxCng== X-Google-Smtp-Source: ABdhPJw3OHa/KfnDP1eX5u9yPnVXyHpsyvjqvNAIiJCIEcH0n6a9Xn4DsL9UahB90tHSeMz9ICNHhA== X-Received: by 2002:a17:902:bc44:: with SMTP id t4mr8920312plz.77.1599243645065; Fri, 04 Sep 2020 11:20:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id gm3sm5689028pjb.31.2020.09.04.11.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 11:20:44 -0700 (PDT) Date: Fri, 4 Sep 2020 11:20:43 -0700 From: Kees Cook To: Ingo Molnar Cc: Nick Desaulniers , Borislav Petkov , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nathan Chancellor , Arnd Bergmann , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , clang-built-linux , linux-arch , linux-efi , Linux ARM , LKML Subject: Re: [PATCH v7 0/5] Warn on orphan section placement Message-ID: <202009041117.5EAC7C242@keescook> References: <20200902025347.2504702-1-keescook@chromium.org> <20200904055825.GA2779622@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904055825.GA2779622@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2020 at 07:58:25AM +0200, Ingo Molnar wrote: > > * Nick Desaulniers wrote: > > > On Tue, Sep 1, 2020 at 7:53 PM Kees Cook wrote: > > > > > > Hi Ingo, > > > > > > The ever-shortening series. ;) Here is "v7", which is just the remaining > > > Makefile changes to enable orphan section warnings, now updated to > > > include ld-option calls. > > > > > > Thanks for getting this all into -tip! > > > > For the series, > > Reviewed-by: Nick Desaulniers > > > > As the recent ppc vdso boogaloo exposed, what about the vdsos? > > * arch/x86/entry/vdso/Makefile > > * arch/arm/vdso/Makefile > > * arch/arm64/kernel/vdso/Makefile > > * arch/arm64/kernel/vdso32/Makefile > > Kees, will these patches DTRT for the vDSO builds? I will be unable to test > these patches on that old system until tomorrow the earliest. I would like to see VDSO done next, but it's entirely separate from this series. This series only touches the core kernel build (i.e. via the interactions with scripts/link-vmlinux.sh) or the boot stubs. So there is no impact on VDSO linking. > I'm keeping these latest changes in WIP.core/build for now. They should be safe to land in -next, which is important so we can shake out any other sneaky sections that all our existing testing hasn't found. :) -- Kees Cook