From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v6 00/20] gpio: cdev: add uAPI v2
Date: Fri, 4 Sep 2020 20:52:50 +0800 [thread overview]
Message-ID: <20200904125250.GA323947@sol> (raw)
In-Reply-To: <20200903083750.GA17445@sol>
On Thu, Sep 03, 2020 at 04:37:50PM +0800, Kent Gibson wrote:
> On Thu, Sep 03, 2020 at 10:02:04AM +0200, Bartosz Golaszewski wrote:
> > On Mon, Aug 31, 2020 at 5:21 AM Kent Gibson <warthog618@gmail.com> wrote:
> > >
[snip]
> >
> > To me it looks good, just a couple nits here and there and some questions.
> >
> > I think it's worth deciding whether we want to keep the selftests in
> > tools/testing/selftests/gpio/ and then maybe consider porting
> > gpio-mockup-chardev.c to V2 or simply outsource it entirely to
> > libgpiod.
> >
>
> Ooops - I wasn't even aware they existed - though it had crossed my mind
> that the kernel should have some selftests somewhere - I use the libgpiod
> tests, from my libgpiod port, and my own Go based test suite for my testing,
> as well as some smoke tests with the tools/gpio.
>
> The libgpiod tests only cover v1 equivalent functionality, while my Go
> tests cover the complete uAPI, and both v1 and v2.
>
> It would be good for the kernel to at least have some smoke tests to
> confirm basic functionality, even thorough testing is left to a
> userspace library. So the existing tests should be ported to v2, though
> should also retain the v1 tests if v1 is still compiled in.
>
I've got a v7 ready to submit that includes a couple of patches for the
gpio-mockup selftests (their primary purpose appears to be testing the
mockup module, rather than the GPIO ABI), but I now notice that the
selftests/gpio section of the tree has a different maintainer:
scripts/get_maintainer.pl 0021-selftests-gpio-port-to-GPIO-uAPI-v2.patch
Bamvor Jian Zhang <bamv2005@gmail.com> (maintainer:GPIO MOCKUP DRIVER)
Shuah Khan <shuah@kernel.org> (maintainer:KERNEL SELFTEST FRAMEWORK)
linux-gpio@vger.kernel.org (open list:GPIO MOCKUP DRIVER)
linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK)
linux-kernel@vger.kernel.org (open list)
The v7 patch up to that point restores the functions that the selftests
are using so that they build and run again.
So I should hold off on the selftest patches and submit them separately
after the GPIO changes are in?
Cheers,
Kent.
next prev parent reply other threads:[~2020-09-04 12:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 3:19 [PATCH v6 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-08-31 3:19 ` [PATCH v6 01/20] gpiolib: cdev: desc_to_lineinfo should set info offset Kent Gibson
2020-08-31 3:19 ` [PATCH v6 02/20] gpiolib: cdev: replace strncpy with strscpy Kent Gibson
2020-08-31 3:19 ` [PATCH v6 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes Kent Gibson
2020-08-31 3:19 ` [PATCH v6 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-09-04 6:23 ` Bartosz Golaszewski
2020-08-31 3:19 ` [PATCH v6 05/20] gpiolib: make cdev a build option Kent Gibson
2020-08-31 3:19 ` [PATCH v6 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-08-31 3:19 ` [PATCH v6 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-09-03 7:42 ` Bartosz Golaszewski
2020-08-31 3:19 ` [PATCH v6 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-08-31 3:19 ` [PATCH v6 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-09-03 7:55 ` Bartosz Golaszewski
2020-09-03 8:09 ` Kent Gibson
2020-09-03 8:13 ` Bartosz Golaszewski
2020-08-31 3:19 ` [PATCH v6 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-08-31 3:19 ` [PATCH v6 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Kent Gibson
2020-09-03 7:59 ` Bartosz Golaszewski
2020-09-03 9:31 ` Kent Gibson
2020-08-31 3:19 ` [PATCH v6 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-08-31 3:19 ` [PATCH v6 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-08-31 3:20 ` [PATCH v6 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-08-31 3:20 ` [PATCH v6 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-08-31 3:20 ` [PATCH v6 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-08-31 3:20 ` [PATCH v6 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-08-31 3:20 ` [PATCH v6 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-08-31 3:20 ` [PATCH v6 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-08-31 3:20 ` [PATCH v6 20/20] tools: gpio: add debounce support " Kent Gibson
2020-09-03 8:02 ` [PATCH v6 00/20] gpio: cdev: add uAPI v2 Bartosz Golaszewski
2020-09-03 8:37 ` Kent Gibson
2020-09-04 12:52 ` Kent Gibson [this message]
2020-09-04 13:02 ` Bartosz Golaszewski
2020-09-08 15:24 ` Shuah Khan
2020-09-08 15:54 ` Bartosz Golaszewski
2020-09-08 16:04 ` Shuah Khan
2020-09-09 1:09 ` Kent Gibson
2020-09-09 1:15 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904125250.GA323947@sol \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).