From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7206EC433E2 for ; Sat, 5 Sep 2020 18:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23ECF2074D for ; Sat, 5 Sep 2020 18:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599331108; bh=RiJx3p6tZX3vdqPValVYqRIYJonUSDkljdfqqiP+ivI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Cp+RpCZNaorN1WoVLnRzvUsGDymQ6/5+IMgpns2f8OA6JdWo6fnc1h1U4LoibmU9s RmXZmZqtHvXeNKg09Tgz8HcZSQaev4Qiy59ABrjsunANHvUBvhLyCnO778pjylMvRd KyJKURgWgRz9nGJf44LT7cttoxooa5+/QNAipV8g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728580AbgIESiY (ORCPT ); Sat, 5 Sep 2020 14:38:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:57842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728393AbgIESiV (ORCPT ); Sat, 5 Sep 2020 14:38:21 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 116B62074D; Sat, 5 Sep 2020 18:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599331101; bh=RiJx3p6tZX3vdqPValVYqRIYJonUSDkljdfqqiP+ivI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AYJf0gVvVsrVa3xgabN92BL2dNFHUnkQ8IToSzTbkQynaCqg9Rc9Aja6504ozX0QB VFh6wBxQXTrMCARG8mire+mVRLCSEWQtgDPclIbCl/QAzrDUBYJ4MzIoHjhDPlVmzR fp57e4uL+am9TVrTzTvSjTahtLLaDO6nwlHctG+A= Date: Sat, 5 Sep 2020 11:38:18 -0700 From: Jakub Kicinski To: Dan Murphy Cc: , , , , , Subject: Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature Message-ID: <20200905113818.7962b6d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200903114259.14013-4-dmurphy@ti.com> References: <20200903114259.14013-1-dmurphy@ti.com> <20200903114259.14013-4-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: > +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) > +{ > + int val, count; > + > + if (cnt > DP83869_DOWNSHIFT_8_COUNT) > + return -E2BIG; ERANGE > + if (!cnt) > + return phy_clear_bits(phydev, DP83869_CFG2, > + DP83869_DOWNSHIFT_EN); > + > + switch (cnt) { > + case DP83869_DOWNSHIFT_1_COUNT: > + count = DP83869_DOWNSHIFT_1_COUNT_VAL; > + break; > + case DP83869_DOWNSHIFT_2_COUNT: > + count = DP83869_DOWNSHIFT_2_COUNT_VAL; > + break; > + case DP83869_DOWNSHIFT_4_COUNT: > + count = DP83869_DOWNSHIFT_4_COUNT_VAL; > + break; > + case DP83869_DOWNSHIFT_8_COUNT: > + count = DP83869_DOWNSHIFT_8_COUNT_VAL; > + break; > + default: > + phydev_err(phydev, > + "Downshift count must be 1, 2, 4 or 8\n"); > + return -EINVAL; > + } > + > + val = DP83869_DOWNSHIFT_EN; > + val |= FIELD_PREP(DP83869_DOWNSHIFT_ATTEMPT_MASK, count); > + > + return phy_modify(phydev, DP83869_CFG2, > + DP83869_DOWNSHIFT_EN | DP83869_DOWNSHIFT_ATTEMPT_MASK, > + val); > +}